Revert "[Metrics] Hide deprecated metrics with gpu_ prefix (#24245)"#25392
Revert "[Metrics] Hide deprecated metrics with gpu_ prefix (#24245)"#25392markmc wants to merge 1 commit intovllm-project:mainfrom
Conversation
…ect#24245)" This change is intended for 0.11.0. This reverts commit 2942970.
markmc
requested review from
DarkLight1337,
NickLucche,
WoosukKwon,
aarnphm,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat,
simon-mo and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a previous commit that hid deprecated metrics with a gpu_ prefix. The revert correctly makes these metrics always visible again by removing the conditional logic. However, there's an inconsistency in the test changes. While the deprecated metrics are un-hidden, the corresponding newer metrics (vllm:kv_cache_usage_perc, etc.) are removed from the EXPECTED_METRICS_V1 test list, even though they are still being emitted by the application. This reduces test coverage, and I've left a comment to address this.
|
Actually let's wait, because @WoosukKwon recently merged most of the V0 deprecation code so there is a chance the release can still be v0.11. cc @simon-mo |
|
From #sig-release-management
|
2 participants
This change is intended for 0.11.0.
This reverts commit 2942970.