[Metrics] Hide deprecated metrics with gpu_ prefix#24245
[Metrics] Hide deprecated metrics with gpu_ prefix#24245mgoin merged 1 commit intovllm-project:mainfrom
Conversation
markmc
requested review from
DarkLight1337,
WoosukKwon,
aarnphm,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat,
simon-mo and
ywang96
as code owners
|
/cc @sahelib25 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to hide deprecated metrics with the gpu_ prefix, making them available only via an escape hatch, and updates the tests accordingly. The logic for hiding the metrics is sound, but it introduces a critical bug where the application would crash if the hidden metrics are not shown, due to uninitialized attributes. My review includes a fix for this bug by providing no-op metric objects when the deprecated metrics are hidden. This ensures the program runs correctly in all configurations.
markmc
force-pushed
the
hide-deprecated-gpu-metrics
branch
2 times, most recently
from
92bf525 to
3ff01b6
Compare
github-actions
bot
added
the
ready
|
metrics test failed |
Head branch was pushed to by a user without write access
markmc
force-pushed
the
hide-deprecated-gpu-metrics
branch
from
3ff01b6 to
4c4972e
Compare
|
This is intended to be merged in 0.11.0, not the 0.10.x series |
In vllm-project#18354, these metrics were deprecated, and the change was included in the v0.9.2 release. We probably should only deprecate things in a v0.N.0 minor release, so let's say these were deprecated in v0.10.0. According to https://docs.vllm.ai/en/latest/usage/metrics.html: > Note: when metrics are deprecated in version X.Y, they are hidden in > version X.Y+1 but can be re-enabled using the > --show-hidden-metrics-for-version=X.Y escape hatch, and are then > removed in version X.Y+2. The deprecated metrics should be hidden in the v0.11.0 release, but with a --show-hidden-metrics-for-version=0.10 escape hatch. They should then be removed in the v0.12.0 release. Signed-off-by: Mark McLoughlin <markmc@redhat.com>
markmc
force-pushed
the
hide-deprecated-gpu-metrics
branch
from
4c4972e to
7d68d9b
Compare
|
Rebased because of flaky structured output tests |
|
Adding back to v0.10.2 milestone, in case it becomes v0.11.0 |
markmc
changed the title
0.10.2 is confirmed, so please re-assign this to 0.11.0 |
Thanks! No 0.11.0 milestone yet, and I can't create one. Removed from 0.10.2 |
markmc
changed the title
|
We have decided the next release to be v0.10.3 instead of v0.11.0, should we revert this in the release branch? |
|
cc @simon-mo |
…ect#24245)" This change is intended for 0.11.0. This reverts commit 2942970.
Yes, see #25392 |
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
4 participants
In #18354, these metrics were deprecated, and the change was included in the v0.9.2 release.
We probably should only deprecate things in a v0.N.0 minor release, so let's say these were deprecated in v0.10.0.
According to https://docs.vllm.ai/en/latest/usage/metrics.html:
The deprecated metrics should be hidden in the v0.11.0 release, but with a --show-hidden-metrics-for-version=0.10 escape hatch.
They should then be removed in the v0.12.0 release.