[spec decode] Consolidate speculative decode method name for MTP#25232
Merged
luccafong merged 6 commits intovllm-project:mainfrom Sep 26, 2025
Merged
[spec decode] Consolidate speculative decode method name for MTP#25232luccafong merged 6 commits intovllm-project:mainfrom
luccafong merged 6 commits intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request consolidates various MTP speculative decoding method names into a unified "mtp" method. The implementation of this consolidation in the configuration and core logic appears correct. However, I've identified a few areas for improvement, primarily in the tests, which are still using deprecated method names, and a misleading warning message. My review includes suggestions to align the tests with the new consolidated method and to clarify the warning message for better user experience.
2de5a65 to
7e9f9da
Compare
benchislett
reviewed
Sep 19, 2025
benchislett
reviewed
Sep 19, 2025
601f399 to
b649014
Compare
5 tasks
luccafong
reviewed
Sep 22, 2025
b649014 to
b306c93
Compare
luccafong
approved these changes
Sep 25, 2025
Collaborator
luccafong
left a comment
There was a problem hiding this comment.
LGTM! thanks for consolidating the codes.
4090c55 to
d9325f6
Compare
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
d9325f6 to
94b8a63
Compare
pdasigi
pushed a commit
to pdasigi/vllm
that referenced
this pull request
Oct 2, 2025
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com>
shyeh25
pushed a commit
to shyeh25/vllm
that referenced
this pull request
Oct 14, 2025
Signed-off-by: zixi-qi <qizixi@meta.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com>
michalkuligowski
pushed a commit
to vllm-project/vllm-gaudi
that referenced
this pull request
Nov 26, 2025
#633) vLLM PR (vllm-project/vllm#25232) has consolidated speculative decode method name for MTP. We need to use "mtp" in the code instead of other names. Signed-off-by: Chen Haifeng <haifeng.chen@intel.com>
HolyFalafel
pushed a commit
to HolyFalafel/vllm-gaudi
that referenced
this pull request
Feb 1, 2026
vllm-project#633) vLLM PR (vllm-project/vllm#25232) has consolidated speculative decode method name for MTP. We need to use "mtp" in the code instead of other names. Signed-off-by: Chen Haifeng <haifeng.chen@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Stack on top of #25221
Currently there are multiple duplicated speculative decode method names for MTP: "deepseek_mtp", "ernie_mtp", "qwen3_next_mtp", "mimo_mtp". This PR consolidates them into one "mtp" method so that we do not need to keep appending this list when creating new models with MTP
Test Plan
Ran unit tests and e2e tests
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.