[spec decode] Add unit tests and e2e test for MTP inference#25221
Closed
zixi-qi wants to merge 2 commits intovllm-project:mainfrom
Closed
[spec decode] Add unit tests and e2e test for MTP inference#25221zixi-qi wants to merge 2 commits intovllm-project:mainfrom
zixi-qi wants to merge 2 commits intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds unit and end-to-end tests for MTP (Multi-Token Prediction) speculative decoding, specifically for the MiMo model. The new tests are well-structured and follow existing patterns. However, I've identified a critical contradiction between the test configurations and a comment in the model's implementation regarding the number of supported speculative tokens. This needs to be resolved to ensure the tests are valid and correctly verify the intended functionality.
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
5 tasks
Collaborator
Author
|
Changes from this PR has been moved to #25232 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add test coverage for MTP inference
Test Plan
Ran the newly added tests
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.