Update to Transformers v4.56.2#24638
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Looks like HF backend for Idefics3 is broken by this upgrade: https://buildkite.com/vllm/ci/builds/30368/steps/canvas?sid=01993997-f436-4816-b6bb-ac9f68f04cc2 |
|
This test is not currently run on main: Even when upgrading to the most similar version, |
|
This test is not currently run on main: When upgrading to @DarkLight1337 I see you labelled this as requiring |
|
The |
|
No, I marked it as v4.56 only because the model isn't in v4.55.0 release |
|
Ok, the |
|
@hmellor I did test it in my local dev environment some time ago (when I put up that PR) and it passed. But I confirm that it doesn't pass on main right now. I will try to see if I can figure out what changed. We are also skip the test for now if it's blocking something. |
@Isotr0py is this patched by #24161 (comment)? |
Yes, and the corresponding fix should be quite similar to Qwen3-VL's video processing implementation. So I will fix it as long as we addressed the Qwen3-VL processing test failure in #24727 (comment) |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Thanks @tdoublep, it would be nice if we could not postpone the fix, but if if's too difficult to solve quickly I can change the reason the test skips so that this PR can be merged. |
|
@hmellor I must have made a mistake previously - I don't see how it could have been working in my local dev environment. The model is broken on transformers because the I can confirm that with that fix the test is passing: |
|
Thanks for the PR @tdoublep! I'll see what I can do about getting it expedited so that we can upgrade to v4.56.2 ASAP |
The processor test should be fixed by #24822. |
|
Can you update this PR? The tests should be pass after #25644 |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
v4.56.1v4.56.2
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Hmm, maybe we still need the changes in transformers backend? |
|
Seems like it, I'll re-add the changes in a more polished way next week |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
I've seen these errors in other PRs that have recently been updated from main |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Supersedes #24043