Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the transformers library from version 4.55.2 to 4.55.3 across the requirement files. The change itself is straightforward. However, I've raised a concern about the version specifier in requirements/common.txt. Using >= can be risky for a project like vLLM that has deep integrations with transformers. I've suggested using a more restrictive pessimistic constraint (~=) to prevent potential breakages from future minor version updates.
github-actions
bot
added
the
ready
|
We should make sure that #24159 is merged before / with this one. |
|
Ok, happy to wait for that one |
|
The Hybrid models tests failure looks related |
|
Pipeline + Context Parallelism Test is also not failing on main so PTAL @hmellor |
|
A new release has come out since I made this PR, I'll make a new one for 4.56.1 |
Pull request was closed
5 participants
Merge after:
tokenizers == 0.22.0#24159