Skip to content

[Core] Simplify and unify mm uuid handling & auto-generated mm hash overrides processing. #24271

Merged
vllm-bot merged 8 commits intovllm-project:mainfrom
huachenheli:simplify
Sep 10, 2025
Merged

[Core] Simplify and unify mm uuid handling & auto-generated mm hash overrides processing. #24271
vllm-bot merged 8 commits intovllm-project:mainfrom
huachenheli:simplify

Conversation

@huachenheli
Copy link
Contributor

@huachenheli huachenheli commented Sep 4, 2025

Purpose

Unify multimodal UUID & hash overrides logic.

After #23690 and #23394, when we auto-generate mm identifiers using f"{request_id}-{modality}-{i}" they effectively serve as uuids which also get hashed later on. So we don't need to track user-provided UUIDs and auto-generated ones (when caching is disabled) separately but rather can simplify the processing flow in a unified manner.

cc. @ywang96 @DarkLight1337

Test Plan

pytest tests/v1/engine/test_processor_multi_modal_uuids.py

CUDA_VISIBLE_DEVICES=0 python -m vllm.entrypoints.openai.api_server --model Qwen/Qwen2.5-VL-3B-Instruct --dtype bfloat16 --limit-mm-per-prompt '{"image":1, "video":1}' --mm_processor_cache_gb=0 --no-enable_prefix_caching with image queries

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
@mergify mergify bot added llama Related to Llama models multi-modality Related to multi-modality (#4194) v1 labels Sep 4, 2025
@mergify
Copy link

mergify bot commented Sep 4, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @huachenheli.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 4, 2025
@mergify mergify bot removed the needs-rebase label Sep 4, 2025
@huachenheli huachenheli changed the title simplify mm uuid & hash overrides [Core] Simplify and unify mm uuid handling & auto-generated mm hash overrides processing. Sep 4, 2025
@huachenheli huachenheli marked this pull request as ready for review September 4, 2025 18:49
@mergify
Copy link

mergify bot commented Sep 8, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @huachenheli.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 8, 2025
@mergify mergify bot removed the needs-rebase label Sep 8, 2025
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 8, 2025
@mergify mergify bot added the deepseek Related to DeepSeek models label Sep 9, 2025
@vllm-bot vllm-bot merged commit 009d689 into vllm-project:main Sep 10, 2025
39 of 41 checks passed
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
…verrides processing. (vllm-project#24271)

Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
…verrides processing. (vllm-project#24271)

Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deepseek Related to DeepSeek models llama Related to Llama models multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants