[Core] Simplify and unify mm uuid handling & auto-generated mm hash overrides processing. #24271
Merged
vllm-bot merged 8 commits intovllm-project:mainfrom Sep 10, 2025
Merged
[Core] Simplify and unify mm uuid handling & auto-generated mm hash overrides processing. #24271vllm-bot merged 8 commits intovllm-project:mainfrom
vllm-bot merged 8 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
c9e1c4f to
52bd56d
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
…verrides processing. (vllm-project#24271) Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…verrides processing. (vllm-project#24271) Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Unify multimodal UUID & hash overrides logic.
After #23690 and #23394, when we auto-generate mm identifiers using
f"{request_id}-{modality}-{i}"they effectively serve as uuids which also get hashed later on. So we don't need to track user-provided UUIDs and auto-generated ones (when caching is disabled) separately but rather can simplify the processing flow in a unified manner.cc. @ywang96 @DarkLight1337
Test Plan
pytest tests/v1/engine/test_processor_multi_modal_uuids.pyCUDA_VISIBLE_DEVICES=0 python -m vllm.entrypoints.openai.api_server --model Qwen/Qwen2.5-VL-3B-Instruct --dtype bfloat16 --limit-mm-per-prompt '{"image":1, "video":1}' --mm_processor_cache_gb=0 --no-enable_prefix_cachingwith image queriesTest Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.