[Multimodal] Generate mm_hash based on request metadata when caching is turned off#23690
Merged
ywang96 merged 16 commits intovllm-project:mainfrom Aug 27, 2025
Merged
Conversation
Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: Roger Wang <hey@rogerw.io>
huachenheli
reviewed
Aug 26, 2025
Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: Roger Wang <hey@rogerw.io>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
…is turned off (vllm-project#23690) Signed-off-by: Roger Wang <hey@rogerw.io>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Sep 3, 2025
…is turned off (vllm-project#23690) Signed-off-by: Roger Wang <hey@rogerw.io>
Merged
5 tasks
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…is turned off (vllm-project#23690) Signed-off-by: Roger Wang <hey@rogerw.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Since #23308 and #22711,
mm_hashis a required information required by the engine core. This introduced a regression when users explicitly specifyenable_prefix_caching=Falseanddisable_mm_preprocessor_cache=True(now asmm_processor_cache_gb=0) since previously mm_data will not be hashed under this scenario but now they will.This PR add
mm_hash_overridesgenerated based onrequest_id, modality string and index of the item in the modality list as the identifier of the item so that hashing is no longer required sincerequest_idis considered unique inside vLLM.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.