[CI] Fix broken compile tests due to unsupported SiluMul+Nvfp4Quant fusion#23973
Merged
vllm-bot merged 3 commits intovllm-project:mainfrom Aug 30, 2025
Merged
[CI] Fix broken compile tests due to unsupported SiluMul+Nvfp4Quant fusion#23973vllm-bot merged 3 commits intovllm-project:mainfrom
vllm-bot merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a crash that occurs when the SiluMul+Nvfp4Quant fusion is attempted on a platform where it's not supported. The change adds a check to ensure the fusion is only registered if the required silu_and_mul_nvfp4_quant op is available. The fix is sound. I have added one comment regarding code duplication which could pose a maintenance risk.
Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
ywang96
approved these changes
Aug 30, 2025
5 tasks
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
…usion (vllm-project#23973) Signed-off-by: Yong Hoon Shin <yhshin@meta.com> Co-authored-by: Roger Wang <hey@rogerw.io>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…usion (vllm-project#23973) Signed-off-by: Yong Hoon Shin <yhshin@meta.com> Co-authored-by: Roger Wang <hey@rogerw.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix failing tests compile/test_pass_manager.py::test_pass_manager_uuid and compile/test_full_graph.py::test_custom_compile_config.
The error is:
This can happen when
hasattr(torch.ops._C, "silu_and_mul_nvfp4_quant")is false. Only enable SiluMul+Nvfp4Quant fusion added in #23671 if supported.Test Plan
Test Result
All tests passed locally, check passes in CI as well.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.