[CI Failure] Skip failing nvfp4 silu test#23959
[CI Failure] Skip failing nvfp4 silu test#23959yewentao256 merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a pragmatic fix for a CI failure in the nvfp4 SILU test. By checking for the existence of the silu_and_mul_nvfp4_quant operator before running the test, it ensures that the test suite doesn't fail in environments where this custom operator isn't compiled. My review includes a suggestion to update the test skip reason to accurately reflect this new condition, which will improve maintainability.
|
Maybe fixed by #23973, let's see https://buildkite.com/vllm/ci/builds/28921/steps/canvas?jid=0198f9d4-fc6b-4e72-89a5-08aa3fac4cd9 |
|
It appears this wasn't fixed by #23973 and it's still impacting CI. So we should probably merge this? |
yewentao256
left a comment
There was a problem hiding this comment.
We should land this first, still PR failing like #23289
This reverts commit e66ed3e. Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
Signed-off-by: mgoin <mgoin64@gmail.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
Signed-off-by: mgoin <mgoin64@gmail.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
Purpose
It seems the Blackwell Test is failing on main since #23929, so skipping if the symbol isn't found for now
Log: https://buildkite.com/vllm/ci/builds/28870/steps/canvas?sid=0198f6b1-3529-46d8-9896-06aac42648d6
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.