[Multimodal] Consolidate mm inputs into MultiModalFeatureSpec#23779
Merged
DarkLight1337 merged 9 commits intovllm-project:mainfrom Aug 29, 2025
Merged
[Multimodal] Consolidate mm inputs into MultiModalFeatureSpec#23779DarkLight1337 merged 9 commits intovllm-project:mainfrom
DarkLight1337 merged 9 commits intovllm-project:mainfrom
Conversation
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Contributor
Author
|
PTAL @ywang96 @DarkLight1337 |
DarkLight1337
approved these changes
Aug 29, 2025
Member
DarkLight1337
left a comment
There was a problem hiding this comment.
Sounds good, thanks for the cleanup!
Contributor
Author
|
Thanks for the review! |
Member
|
The test fails, PTAL |
auto-merge was automatically disabled
August 29, 2025 07:05
Head branch was pushed to by a user without write access
Contributor
Author
Should be fixed now, will monitor the CI. |
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
…roject#23779) Signed-off-by: sfeng33 <4florafeng@gmail.com>
Merged
5 tasks
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…roject#23779) Signed-off-by: sfeng33 <4florafeng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR refactors multimodal input in V1 engine to use a unified MultiModalFeatureSpec data structure, as part of the broader effort to abstract out vllm's input processing pipeline (#22880).
Partially fix: #23872
Why This Change:
This refactor addresses the fragmented input processing issue where multimodal data (images, audio, video) was passed through multiple separate fields (mm_kwargs, mm_hashes, mm_placeholders).
Changes
Note: To keep the PR small, only updated core engine and processor references. Left TODO comments for migrating
scheduler and model runner in follow-up PRs
Test Plan