Skip to content

[Bugfix] Fix PlaceholderRange import error#613

Merged
kyuyeunk merged 1 commit intomainfrom
fix_placeholderrange_error
Aug 29, 2025
Merged

[Bugfix] Fix PlaceholderRange import error#613
kyuyeunk merged 1 commit intomainfrom
fix_placeholderrange_error

Conversation

@kyuyeunk
Copy link
Collaborator

Description

After upstream change in vllm-project/vllm#23779, tests/runner/jax/test_multimodal_manager.py test fails with below error. This PR fixes this issue.

==================================== ERRORS ====================================
--
  | _________ ERROR collecting tests/runner/jax/test_multimodal_manager.py _________
  | ImportError while importing test module '/workspace/tpu_commons/tests/runner/jax/test_multimodal_manager.py'.
  | Hint: make sure your test modules/packages have valid Python names.
  | Traceback:
  | /usr/local/lib/python3.12/importlib/__init__.py:90: in import_module
  | return _bootstrap._gcd_import(name[level:], package, level)
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  | tests/runner/jax/test_multimodal_manager.py:12: in <module>
  | from vllm.v1.request import PlaceholderRange
  | E   ImportError: cannot import name 'PlaceholderRange' from 'vllm.v1.request' (/workspace/vllm/vllm/v1/request.py)

Tests

pytest tests/runner/jax/test_multimodal_manager.py

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
@kyuyeunk kyuyeunk merged commit 256b977 into main Aug 29, 2025
1 of 3 checks passed
@kyuyeunk kyuyeunk deleted the fix_placeholderrange_error branch August 29, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants