-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Bugfix] Fix granite speech shape validation #21762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix granite speech shape validation #21762
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a shape validation issue in GraniteSpeechAudioInputs by updating the TensorShape for input_features_mask. The change from nf to fi and the introduction of fo also improve clarity. I have one suggestion to make the documentation for the new fo dimension even clearer to prevent future confusion.
| - b: Batch size | ||
| - nf: Number of audio features (variable length) | ||
| - fi: Number of input features from the Mel spectrogram. | ||
| - fo: Number of output features, i.e. the embedding size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "embedding size" is ambiguous. It is commonly used to refer to the dimensionality of an embedding vector (e.g., the hidden size), but here fo represents the number of output feature vectors (i.e., the sequence length of the embeddings). This could cause confusion for future developers.
To improve clarity, I suggest rephrasing this to avoid ambiguity.
| - fo: Number of output features, i.e. the embedding size. | |
| - fo: Number of output features (i.e., number of embeddings). |
|
@DarkLight1337 Acknowledging bug introduced from changes. Thanks for the fix! |
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Yeah we really need #21754 to avoid this issue...
Test Plan
Test Result
(Optional) Documentation Update