Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jul 28, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Yeah we really need #21754 to avoid this issue...

Test Plan

Test Result

(Optional) Documentation Update

@DarkLight1337 DarkLight1337 requested a review from Isotr0py July 28, 2025 14:29
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 28, 2025
@DarkLight1337 DarkLight1337 changed the title Fix granite speech shape validation [Bugfix] Fix granite speech shape validation Jul 28, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a shape validation issue in GraniteSpeechAudioInputs by updating the TensorShape for input_features_mask. The change from nf to fi and the introduction of fo also improve clarity. I have one suggestion to make the documentation for the new fo dimension even clearer to prevent future confusion.

- b: Batch size
- nf: Number of audio features (variable length)
- fi: Number of input features from the Mel spectrogram.
- fo: Number of output features, i.e. the embedding size.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The term "embedding size" is ambiguous. It is commonly used to refer to the dimensionality of an embedding vector (e.g., the hidden size), but here fo represents the number of output feature vectors (i.e., the sequence length of the embeddings). This could cause confusion for future developers.

To improve clarity, I suggest rephrasing this to avoid ambiguity.

Suggested change
- fo: Number of output features, i.e. the embedding size.
- fo: Number of output features (i.e., number of embeddings).

@mgoin mgoin merged commit e17a4d3 into vllm-project:main Jul 28, 2025
70 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-granite-speech-shape branch July 29, 2025 01:32
@bbeckca
Copy link
Contributor

bbeckca commented Jul 29, 2025

@DarkLight1337 Acknowledging bug introduced from changes. Thanks for the fix!

liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants