Skip to content

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Jul 28, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

  • Since some large LMMs aren't run on CI due to memory limitation, we should make sure newly added tensor schema won't break anything.
  • Add test to cover tensor schema validation for each multimodal model.

Test Plan

pytest -s -v tests/models/multimodal/test_tensor_schema.py

Test Result

  • Test should pass without any error.

(Optional) Documentation Update

Signed-off-by: Isotr0py <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Jul 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test to validate tensor schemas for multimodal models, which is a valuable addition for ensuring model input correctness. The overall approach is sound, but I've identified a few areas for improvement. The test currently only covers a single model architecture, uses internal APIs, and is specific to the V0 engine. My feedback focuses on expanding test coverage, improving maintainability by using public APIs, and, most importantly, updating the test to be compatible with the V1 engine to ensure its long-term value.

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py marked this pull request as ready for review July 30, 2025 16:56
Isotr0py added 3 commits July 31, 2025 21:50
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
Copy link
Member Author

Isotr0py commented Jul 31, 2025

Refer to https://buildkite.com/vllm/fastcheck/builds/33014#01985c44-e73a-4cb8-8fd4-68684f687912

  | [2025-07-30T19:34:16Z] FAILED models/multimodal/test_tensor_schema.py::test_model_tensor_schema[DeepseekVLV2ForCausalLM] - ValueError: data has rank 5 but expected 4
  | [2025-07-30T19:34:16Z] FAILED models/multimodal/test_tensor_schema.py::test_model_tensor_schema[H2OVLChatModel] - pydantic_core._pydantic_core.ValidationError: 1 validation error for ModelConfig
  | [2025-07-30T19:34:16Z]   Value error, The repository h2oai/h2ovl-mississippi-800m contains custom code which must be executed to correctly load the model. You can inspect the repository content at https://hf.co/h2oai/h2ovl-mississippi-800m .
  | [2025-07-30T19:34:16Z]  You can inspect the repository content at https://hf.co/h2oai/h2ovl-mississippi-800m.
  | [2025-07-30T19:34:16Z] Please pass the argument `trust_remote_code=True` to allow custom code to be run. [type=value_error, input_value=ArgsKwargs(('h2oai/h2ovl-...se, 'hf_overrides': {}}), input_type=ArgsKwargs]
  | [2025-07-30T19:34:16Z]     For further information visit https://errors.pydantic.dev/2.11/v/value_error
  | [2025-07-30T19:34:16Z] FAILED models/multimodal/test_tensor_schema.py::test_model_tensor_schema[KeyeForConditionalGeneration] - ValueError: pixel_values has rank 5 but expected 2
  | [2025-07-30T19:34:16Z] FAILED models/multimodal/test_tensor_schema.py::test_model_tensor_schema[MiniMaxVL01ForConditionalGeneration] - ValueError: The expected shape of pixel values is ('batch_size', '3', '336', '336'). You supplied (3, 19, 3, 336, 336).
  | [2025-07-30T19:34:16Z] = 4 failed, 131 passed, 31 skipped, 923 deselected, 104 warnings in 4275.53s (1:11:15) =

Broken models due to TensorSchema:

  • DeepseekVLV2ForCausalLM
  • KeyeForConditionalGeneration

Possible broken models unrelated to TensorSchema:

  • MiniMaxVL01ForConditionalGeneration!?

@Isotr0py Isotr0py marked this pull request as draft July 31, 2025 15:44
@DarkLight1337
Copy link
Member

@bbeckca please hold off on additional PRs until this is merged, otherwise you will have to merge these changes into many PRs.

@mergify mergify bot added the deepseek Related to DeepSeek models label Aug 1, 2025
Signed-off-by: Isotr0py <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 2, 2025 04:35
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 2, 2025
@DarkLight1337 DarkLight1337 disabled auto-merge August 2, 2025 04:35
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@mergify mergify bot added the ci/build label Aug 2, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Isotr0py for improving model coverage and fixes! Please feel free to share any feedback to help make these changes safer in the future.

@DarkLight1337
Copy link
Member

PTAL at the failing tests

@vllm-bot vllm-bot merged commit 3dddbf1 into vllm-project:main Aug 3, 2025
69 of 73 checks passed
@Isotr0py Isotr0py deleted the tensor-scheme-test branch August 3, 2025 08:02
@DarkLight1337
Copy link
Member

Sorry I missed that models/multimodal/test_tensor_schema.py::test_model_tensor_schema[Glm4MoeForCausalLM] is failing, can you fix it?

npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build deepseek Related to DeepSeek models multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants