-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Misc] Add tensor schema test coverage for multimodal models #21754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new test to validate tensor schemas for multimodal models, which is a valuable addition for ensuring model input correctness. The overall approach is sound, but I've identified a few areas for improvement. The test currently only covers a single model architecture, uses internal APIs, and is specific to the V0 engine. My feedback focuses on expanding test coverage, improving maintainability by using public APIs, and, most importantly, updating the test to be compatible with the V1 engine to ensure its long-term value.
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
|
Refer to https://buildkite.com/vllm/fastcheck/builds/33014#01985c44-e73a-4cb8-8fd4-68684f687912 Broken models due to
Possible broken models unrelated to
|
|
@bbeckca please hold off on additional PRs until this is merged, otherwise you will have to merge these changes into many PRs. |
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Isotr0py for improving model coverage and fixes! Please feel free to share any feedback to help make these changes safer in the future.
|
PTAL at the failing tests |
Signed-off-by: Isotr0py <[email protected]>
|
Sorry I missed that |
…oject#21754) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
…oject#21754) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…oject#21754) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Noam Gat <[email protected]>
…oject#21754) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…oject#21754) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…oject#21754) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
…oject#21754) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update