Skip to content

Adding "Basic Models Test" and "Multi-Modal Models Test (Extended) 3" in AMD Pipeline #18106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 10 commits into from
May 15, 2025
Merged

Adding "Basic Models Test" and "Multi-Modal Models Test (Extended) 3" in AMD Pipeline #18106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4b6d446
Adding new test.
Alexei-V-Ivanov-AMD May 12, 2025
1d3473d
Merge branch 'vllm-project:main' into amd_experimental_all_tests_upda…
Alexei-V-Ivanov-AMD May 12, 2025
b067a92
Adding "Basic Models Test" and "Multi-Modal Models Test (Extended) 3"
Alexei-V-Ivanov-AMD May 13, 2025
3e76974
Update tests/models/test_transformers.py
Alexei-V-Ivanov-AMD May 14, 2025
1458f4c
Update tests/models/test_transformers.py
Alexei-V-Ivanov-AMD May 14, 2025
283559e
Update test_transformers.py
Alexei-V-Ivanov-AMD May 14, 2025
94c4580
Fixed imports.
Alexei-V-Ivanov-AMD May 14, 2025
f5e63d1
Merge branch 'amd_experimental_all_tests_updated_20250512' of github.…
Alexei-V-Ivanov-AMD May 14, 2025
182dec0
Fixing pre-commit.
Alexei-V-Ivanov-AMD May 15, 2025
194711a
Reverting requirements/test.txt
Alexei-V-Ivanov-AMD May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .buildkite/scripts/hardware_ci/run-amd-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ if [[ $commands == *"pytest -v -s basic_correctness/test_basic_correctness.py"*
commands=${commands//"pytest -v -s basic_correctness/test_basic_correctness.py"/"VLLM_USE_TRITON_FLASH_ATTN=0 pytest -v -s basic_correctness/test_basic_correctness.py"}
fi

if [[ $commands == *"pytest -v -s models/test_registry.py"* ]]; then
commands=${commands//"pytest -v -s models/test_registry.py"/"pytest -v -s models/test_registry.py -k 'not BambaForCausalLM and not GritLM and not Mamba2ForCausalLM and not Zamba2ForCausalLM'"}
fi

if [[ $commands == *"VLLM_USE_V1=0 pytest -v -s models/test_initialization.py -k 'not llama4 and not plamo2'"* ]]; then
commands=${commands//"VLLM_USE_V1=0 pytest -v -s models/test_initialization.py -k 'not llama4 and not plamo2'"/"VLLM_USE_V1=0 pytest -v -s models/test_initialization.py -k 'not llama4 and not plamo2 and not BambaForCausalLM and not Gemma2ForCausalLM and not Grok1ModelForCausalLM and not Zamba2ForCausalLM and not Gemma2Model and not GritLM'"}
fi

if [[ $commands == *"pytest -v -s compile/test_basic_correctness.py"* ]]; then
commands=${commands//"pytest -v -s compile/test_basic_correctness.py"/"VLLM_USE_TRITON_FLASH_ATTN=0 pytest -v -s compile/test_basic_correctness.py"}
fi
Expand Down
6 changes: 3 additions & 3 deletions .buildkite/test-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ steps:
##### models test #####

- label: Basic Models Test # 24min
mirror_hardwares: [amdexperimental]
mirror_hardwares: [amdexperimental, amdproduction]
torch_nightly: true
source_file_dependencies:
- vllm/
Expand Down Expand Up @@ -527,7 +527,7 @@ steps:
- pytest -v -s models/multimodal/generation/test_common.py -m 'split(group=0) and not core_model'

- label: Multi-Modal Models Test (Extended) 3
mirror_hardwares: [amdexperimental]
mirror_hardwares: [amdexperimental, amdproduction]
optional: true
source_file_dependencies:
- vllm/
Expand All @@ -537,7 +537,7 @@ steps:
- pytest -v -s models/multimodal/generation/test_common.py -m 'split(group=1) and not core_model'

- label: Quantized Models Test
mirror_hardwares: [amdexperimental]
mirror_hardwares: [amdexperimental, amdproduction]
source_file_dependencies:
- vllm/model_executor/layers/quantization
- tests/models/quantization
Expand Down
6 changes: 6 additions & 0 deletions requirements/rocm-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,10 @@ decord==0.6.0
#sentence-transformers # required by entrypoints/openai/test_score.py
sentence-transformers==3.4.1

# Basic Models Test
matplotlib==3.10.3

# Multi-Modal Models Test (Extended) 3
blobfile==3.0.0


8 changes: 8 additions & 0 deletions tests/models/test_transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
"""Test the functionality of the Transformers backend."""
import pytest

from vllm.platforms import current_platform

from ..conftest import HfRunner, VllmRunner
from ..utils import multi_gpu_test
from .utils import check_logprobs_close
Expand Down Expand Up @@ -33,6 +35,9 @@ def check_implementation(
)


@pytest.mark.skipif(
current_platform.is_rocm(),
reason="Llama-3.2-1B-Instruct, Ilama-3.2-1B produce memory access fault.")
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix pre-commit before I can merge the PR

@pytest.mark.parametrize(
"model,model_impl",
[
Expand Down Expand Up @@ -64,6 +69,9 @@ def test_distributed(
"meta-llama/Llama-3.2-1B-Instruct", **kwargs)


@pytest.mark.skipif(
current_platform.is_rocm(),
reason="bitsandbytes quantization is currently not supported in rocm.")
@pytest.mark.parametrize("model, quantization_kwargs", [
(
"meta-llama/Llama-3.2-1B-Instruct",
Expand Down