Skip to content

Adding "Basic Models Test" and "Multi-Modal Models Test (Extended) 3" in AMD Pipeline#18106

Merged
vllm-bot merged 10 commits intovllm-project:mainfrom
Alexei-V-Ivanov-AMD:amd_experimental_all_tests_updated_20250512
May 15, 2025
Merged

Adding "Basic Models Test" and "Multi-Modal Models Test (Extended) 3" in AMD Pipeline#18106
vllm-bot merged 10 commits intovllm-project:mainfrom
Alexei-V-Ivanov-AMD:amd_experimental_all_tests_updated_20250512

Conversation

@Alexei-V-Ivanov-AMD
Copy link
Collaborator

@Alexei-V-Ivanov-AMD Alexei-V-Ivanov-AMD commented May 13, 2025

Adding "Basic Models Test" and "Multi-Modal Models Test (Extended) 3" in AMD Pipeline

Signed-off-by: Alexei V. Ivanov alexei.ivanov@amd.com

Alexei-V-Ivanov-AMD and others added 3 commits May 12, 2025 14:42
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 13, 2025
Alexei-V-Ivanov-AMD and others added 3 commits May 13, 2025 23:00
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>

Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>

Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
@DarkLight1337
Copy link
Member

Pre-commit is still failing

@houseroad houseroad added the rocm Related to AMD ROCm label May 14, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
…com:Alexei-V-Ivanov-AMD/vllm into amd_experimental_all_tests_updated_20250512
@Alexei-V-Ivanov-AMD
Copy link
Collaborator Author

@DarkLight1337

Pre-commit is still failing

Both tests are green (https://buildkite.com/vllm/fastcheck/builds/23953)

Please merge this PR.

Thanks!



@pytest.mark.skipif(current_platform.is_rocm(),
reason="Llama-3.2-1B-Instruct, Ilama-3.2-1B produce memory access fault.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix pre-commit before I can merge the PR

@khluu
Copy link
Collaborator

khluu commented May 15, 2025

can you fix precommit?

Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
@Alexei-V-Ivanov-AMD
Copy link
Collaborator Author

@khluu

can you fix precommit?

Fixed.

@vllm-bot vllm-bot merged commit 566ec04 into vllm-project:main May 15, 2025
4 of 9 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
… in AMD Pipeline (vllm-project#18106)

Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants