[WIP] Add support for HuggingFace Chat Templates#1365
Closed
Tostino wants to merge 34 commits into
Closed
Conversation
…o a json template. Added to quickstart.rst and example json file in the examples folder.
…r a manually specified template file.
…o a json template. Added to quickstart.rst and example json file in the examples folder.
…r a manually specified template file.
…p, must have been ide formatting things and I didn't notice.
This was referenced Oct 16, 2023
Co-authored-by: squeeze-ai-lab <squeezeailab.bair@gmail.com> Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
…o a json template. Added to quickstart.rst and example json file in the examples folder.
…r a manually specified template file.
…p, must have been ide formatting things and I didn't notice.
Contributor
Author
|
Well, I somehow just messed up this branch. Will get that fixed. Also got some feedback on Discord to remove FastChat dependency. |
Tostino
changed the title
Contributor
Author
|
Closed, and replaced by: #1493 |
pi314ever
pushed a commit
to pi314ever/vllm
that referenced
this pull request
Jun 23, 2025
Signed-off-by: zhouyu5 <yu.zhou@intel.com> Co-authored-by: Jan Kaniecki <jan.kaniecki@intel.com>
minmin-intel
pushed a commit
to minmin-intel/vllm
that referenced
this pull request
Jul 15, 2025
…ject#1479) Signed-off-by: zhouyu5 <yu.zhou@intel.com> Co-authored-by: Yu-Zhou <yu.zhou@intel.com> Co-authored-by: Jan Kaniecki <jan.kaniecki@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, I revised my prior PR to instead implement the HF Chat Template support: https://huggingface.co/docs/transformers/main/en/chat_templating
This PR has support for tokenizers which have added a template, and also supports specifying a jinja2 template file through command-line arguments for models which haven't added the template to the tokenizer, or if a user wanted to modify the template.