Skip to content

Jinja instruct templates#4202

Closed
oobabooga wants to merge 1 commit into
mainfrom
jinja
Closed

Jinja instruct templates#4202
oobabooga wants to merge 1 commit into
mainfrom
jinja

Conversation

@oobabooga
Copy link
Copy Markdown
Owner

@oobabooga oobabooga marked this pull request as draft October 6, 2023 15:55
@Ph0rk0z
Copy link
Copy Markdown
Contributor

Ph0rk0z commented Oct 9, 2023

We won't have to eat their "Assistant is helpful and harmless" system messages from this, will we?

@Tostino
Copy link
Copy Markdown

Tostino commented Oct 16, 2023

@oobabooga Just FYI, I have implemented this for vLLM's OpenAI api: vllm-project/vllm#1365

Was pretty straight forward.

@Ph0rk0z no...those are just examples. The template itself will determine what the template does. Some models may have a hard coded system message in their template, others will allow a configurable system message. Just depends.

@Dampfinchen
Copy link
Copy Markdown

GGUF now supports Instruct templates.

@oobabooga
Copy link
Copy Markdown
Owner Author

Moved to #4874

@oobabooga oobabooga closed this Dec 11, 2023
@oobabooga oobabooga deleted the jinja branch December 11, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants