Repository navigation
[cherry-pick][release/v0.32.0] cherry-pick #9270: warn on TaylorSeer order>=2 and document the Ref2VA artifact margin - #9274
Conversation
ea25c64 to
90189c8
Compare
…acts TaylorSeer order-2 extrapolation produced a localized translucent dark artifact on 10s Ref2VA videos when the cache window extends beyond the validated max_continuous_cached_steps=4 (same-seed A/B against the uncached path, dense attention; independent controlled run and error probe in issue comments; vllm-project#8805). Warn at calibrator build time when a cache config leaves the validated envelope - order 2 with max_continuous_cached_steps above the validated window, or any order above 2 (which has no validated window) - and document the validated window plus the Cache-DiT + DLO memory margin on 64GB-class dies in the MiniMax-H3 recipe. Signed-off-by: GUOGUO <xwdong1998@163.com>
90189c8 to
1c5206d
Compare
|
@Gaohan123 — the main-branch PR (#9270) is merged; this is the corresponding |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR appears to belong to: docs/design/module/cache_management.md, docs/design/module/diffusion/index.md. Module owners: @david6666666 @Isotr0py @princepride Routing: @david6666666 via module of the changed files, module named in the PR description, model owner; @Isotr0py via module of the changed files, module named in the PR description, CODEOWNERS; @princepride via module of the changed files, module named in the PR description @Dong1017, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Omni ReviewBot triage noteAutomated triage of commit
These are automated triage suggestions only — the final decision belongs to the maintainers. |
Purpose
Backport of #9270 to
release/v0.32.0(mitigates #8805 on the release line).Warn at calibrator-build time when a Cache-DiT config leaves the validated envelope:
taylorseer_orderabove 2 (no validated window), ortaylorseer_order == 2withmax_continuous_cached_stepsabove the validated window of 4 (localized dark artifact on 10 s Ref2VA videos, evidence in #8805). Document the validated cache window plus the Cache-DiT + DLO memory margin on 64 GB-class dies in the MiniMax-H3 recipe.Test Plan
pytest tests/diffusion/cache/test_cache_dit.py— the four new warning tests (order 2 with the window above the validated 4 warns; order 2 at the validated window stays silent; order 3 warns even at the validated window; order 1 stays silent). Assertions check a stable warning fragment viacaplog.records.Test Result
requirements/common.txt, this branch):taylorseersubset 6 passed (the four new tests plus existing matches).🤖 Generated with Claude Code