Repository navigation
[CI][ROCm] Add LingBot nightly coverage - #7935
Conversation
|
This PR was classified as CI work. CI owner: @yenuo26 @congw729 @NickCao Routing: @yenuo26 via semantic router, CI owner, CODEOWNERS; @congw729 via CODEOWNERS; @NickCao via CODEOWNERS @haic0, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Self-reviewUpdated after the true rebase. I reviewed every final changed line on exact head
Residual validation is an exact-head MI300 checkpoint run. The local environment lacks vLLM, so exact model collection and GPU execution were not rerun. |
Omni ReviewBot: no human activity for 7 days@haic0 this pull request has had no human commit, comment or review since 2026-09-22. Please confirm the current plan and next step. The author or a maintainer decides whether to change the PR state. To keep it moving, any one of these is enough: push an update, reply to the open blocker, or post the current plan and timeline. |
57b74cd to
6b2581e
Compare
|
Addressed all four review comments in
Validation: generic AMD tests 26 passed; whole-file marker collection produced ROCm=1 ( |
6b2581e to
2771820
Compare
Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
2771820 to
4a83268
Compare
Purpose
Add a dedicated non-blocking AMD nightly job for the dense
robbyant/lingbot-video-dense-1.3bCFG-off smoketests/e2e/online_serving/test_lingbot_video_expansion.py::test_cfg_off.The job uses one MI300 (
mi300_1), a 90-minute timeout, the exactfull_model and diffusion and rocm and MI325 and cards_1selector, fail-closed collect-only preflight, and checkout-relative JUnit staging underartifacts/rocm-lingbot-nightly/. The shared AMD MiniJinja template suppliesdepends_on: amd-build.Why this is not a duplicate
Open and merged PR searches found no existing LingBot AMD nightly coverage. #7892 adds complementary CUDA routing, while #7933 and #7934 cover different model families.
Final rebase and validation
aad30908772a8188c17997341d62768dc0bab3b7277182032a650d7a9e7f2d0f0522f841b14bf3e2git diff --check, Unicode format-control scan, and DCO/trailer audit: passed.Assisted-by: CursorandSigned-off-by: haic0 <149741444+haic0@users.noreply.github.com>.ROCm eligibility remains limited to
test_cfg_off;test_batch_cfg_extra_paramsremains CUDA-only. Exact model collection and MI300 execution were not rerun because this lightweight environment lacks vLLM. No exact-head GPU/model run is claimed.