Repository navigation
[CI][ROCm] Add and stabilize HunyuanImage3 nightly coverage - #7934
Conversation
|
This PR appears to be related to model: HunyuanImage. Model owners: @Bounty-hunter @yenuo26 @congw729 Routing: @Bounty-hunter via model owner; @yenuo26 via CI owner, CODEOWNERS; @congw729 via CODEOWNERS @haic0, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Self-reviewUpdated after the true rebase. I reviewed every final changed line on exact head
Residual validation is an exact-head MI300 model run. The local environment lacks vLLM, so exact model collection and GPU execution were not rerun. |
Omni ReviewBot triage noteResolved as of |
Omni ReviewBot: no human activity for 7 days@haic0 this pull request has had no human commit, comment or review since 2026-09-22. Please confirm the current plan and next step. The author or a maintainer decides whether to change the PR state. To keep it moving, any one of these is enough: push an update, reply to the open blocker, or post the current plan and timeline. |
|
Addressed both yenuo26 review threads in
Validation: native MiniJinja 2.3.1 render plus YAML semantic checks passed; generic AMD pipeline suite passed (7 tests); changed-file pre-commit and |
63cf3e2 to
9fc31c1
Compare
9fc31c1 to
7fe818a
Compare
7fe818a to
8a3060c
Compare
Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: andyluo7 <andy.luo@amd.com>
daa897b to
e52c180
Compare
Purpose
Add non-blocking ROCm nightly coverage for HunyuanImage3 and make that coverage reliable on AMD hardware.
The nightly job runs
tests/e2e/accuracy/test_hunyuan_image3_pixel_accuracy.py::test_hunyuan_image3_pixel_accuracy_offlinewithtencent/HunyuanImage-3.0-Instructon four MI300 GPUs. It uses thefull_model and rocm and MI325 and cards_4selector,--run-level full_model, a fail-closed collect-only preflight,TORCH_SDPA, the platform-native automatic ROCm MoE backend, and uploads PNG/JUnit artifacts underartifacts/rocm-hunyuanimage3/.ROCm stabilization
29.0. CUDA keeps its existing default/B200 thresholds and NPU keeps26.0.Validation
Qualified PR head:
e52c180504c98126784d6b4f092cf17960c4ec20mi300_4: HunyuanImage3 Offline Pixel Accuracypassed without retry.0.0053280.0470590.99219837.103355 dB(ROCm threshold:29.0 dB)hunyuanimage3-pytest.xmlandvllm_omni_offline.png.HunyuanImage3-DIT · Accuracy Testpassed 3 tests without retry.The PR was squash-merged as
a0d915254b4815b085d6d713de73e3ea6c76a0be. Its stable patch ID matches the qualified PR diff exactly.