Skip to content

[Bugfix] Release H3 chunked MP4 workers - #7638

Draft
0z5a wants to merge 21 commits into
vllm-project:mainfrom
0z5a:fix/h3-chunked-mp4-workers
Draft

0z5a wants to merge 21 commits into
vllm-project:mainfrom
0z5a:fix/h3-chunked-mp4-workers

Conversation

@0z5a

@0z5a 0z5a commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Current A100 validation at ae3f5a9b692b (2×A100 40GB; Torch 2.13.0+cu130, vLLM 0.30.0).

Check Baseline Current result Speedup
Native scoped regression suite N/A 16 passed at 4552e981c383; entire file tree unchanged N/A
A100 full-model high-concurrency comparison Pending Pending Pending

Full trained MiniMax-H3 FL2VA decode and native MP4 worker completion under high concurrency remain pending.

Current incremental diff against the forked prerequisite (2 paths).

The instance was externally stopped during the remaining test queue. All completed results above were saved off-instance; unfinished measurements remain pending.

Purpose

Depends on unmerged #7519. This Draft carries that prerequisite in the main diff; review the follow-up in commit 8b93e5d, which changes only two files.

Move lishunyang12/vllm-omni#62 to the upstream repository. Related to #7415 (P5 output pipeline).

Extend the MiniMax-H3 chunked MP4 sink's exception handling across setup, decoding and finalization, releasing its worker on failure before handoff. Successful calls still transfer ownership to the caller. Restore the chunk_value_range = (0.0, 1.0) capability declaration.

Test Plan

python -m pytest tests/diffusion/models/minimax_h3/test_chunked_output_lifecycle.py

Parent: 7ba27060000028a1ab5fc86058271e1fb9f9da29. vLLM 0.29.0, PyTorch 2.13.0+cu130, Python 3.12.3.

Test Result

Existing validation of the identical source tree, before this metadata-only republication:

  • Lifecycle regression: 16 passed; unchanged parent: 8 failed / 8 passed.
  • Lifecycle plus VAE tiling/chunk suites: 49 passed.
  • CUDA/pinned D2H/PyAV integration: 14 passed; four 107-frame MP4 variants byte-identical before/after.
  • Pretrained VAE: pixels and MP4 bytes match the reference for three shapes up to 107 frames at 256×448 on one RTX PRO 4000 Blackwell; post-decode failure releases the worker. This used a separate validation-only checkpoint callback extension.
  • Applicable pre-commit hooks passed, including mypy and test marks.

Full pretrained-model service E2E and multi-GPU failure recovery are not qualified by these results. DLO shutdown changes remain separate in #7581.

Test and benchmark sources are retained locally; the validation results below refer to those local files.

Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
@hsliuustc0106 hsliuustc0106 added bug Something isn't working diffusion codes related to diffusion models labels Sep 16, 2026
@hsliuustc0106

Copy link
Copy Markdown
Collaborator

This PR touches vllm_omni/diffusion/, tests/diffusion/, docs/user_guide/, recipes/MiniMaxAI/, tools/minimax_h3/ (49 files). Based on CODEOWNERS coverage of the changed files, the most-related reviewers appear to be:

@wtomin @Bounty-hunter @fhfuih

Could one of you take a look when you get a chance? Thanks!

0z5a added a commit to 0z5a/vllm-omni that referenced this pull request Sep 23, 2026
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
0z5a added a commit to 0z5a/vllm-omni that referenced this pull request Sep 24, 2026
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
@0z5a
0z5a force-pushed the fix/h3-chunked-mp4-workers branch from 77b2d49 to 5d35482 Compare September 24, 2026 06:40
lishunyang12 and others added 11 commits September 24, 2026 15:13
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: Dezhen Lu <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
@0z5a
0z5a force-pushed the fix/h3-chunked-mp4-workers branch from 5d35482 to a30381e Compare September 24, 2026 07:13
0z5a and others added 5 commits October 1, 2026 02:21
Signed-off-by: 0z5a <Dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <Dezhen.lu@student.uni-tuebingen.de>
Signed-off-by: 0z5a <192209249+0z5a@users.noreply.github.com>
Signed-off-by: 0z5a <192209249+0z5a@users.noreply.github.com>
Signed-off-by: 0z5a <192209249+0z5a@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working diffusion codes related to diffusion models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants