Repository navigation
[Model] Accelerate MiniMax-H3 end-to-end inference - #7519
Draft
lishunyang12 wants to merge 5 commits into
Draft
lishunyang12 wants to merge 5 commits into
lishunyang12 wants to merge 5 commits into
Conversation
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
This was referenced Sep 14, 2026
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Signed-off-by: lishunyang12 <lishunyang12@users.noreply.github.com>
Collaborator
|
This PR touches vllm_omni/diffusion/, tests/diffusion/, docs/user_guide/, recipes/MiniMaxAI/, tools/minimax_h3/ (51 files). Based on CODEOWNERS coverage of the changed files, the most-related reviewers appear to be: Could one of you take a look when you get a chance? Thanks! |
This was referenced Sep 15, 2026
Closed
Collaborator
|
Ready for full review when draft status is removed and the merge conflicts are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7415
Spliting into
Module layout and validation
The H3 directory now has 39 Python modules instead of 45. Component quantization policy, VAE batching, VAE parallel output and VSA producer lifetime are consolidated; the model-specific VSA entry is
attention/vsa.py. Shared platform selection, transport and operators retain their owners. No VDN implementation or new dependency is added.At
7ba27060, the related regression group reports 337 passed, 20 failed. All 20 failures also occur in the pre-changedda16f4bcheckout after removing its unsupportedOffloadPlan.resident_offload_submoduleskeyword solely to allow imports (that comparison reports 327 passed, 21 failed). Nine implementation-adapter tests are brought over from P1, and its dispatch typing fix resolves the remaining one-test difference. The outstanding failures concern media output/capability contracts and fixtures missing acceleration state; this draft is not merge-qualified.Pre-commit passes. All 61 moved function/class ASTs match after explicit import and symbol normalization. The consolidated modules import with optional kernel-provider imports blocked. No full-model E2E or VDN qualification was run.