Skip to content

[Frontend] Add MiniMax-H3 reference-to-video workflow - #7559

Closed
LinzeShi wants to merge 2 commits into
vllm-project:mainfrom
LinzeShi:feat/comfyui-h3-reference-workflow
Closed

LinzeShi wants to merge 2 commits into
vllm-project:mainfrom
LinzeShi:feat/comfyui-h3-reference-workflow

Conversation

@LinzeShi

Copy link
Copy Markdown
Contributor

Summary

Add the MiniMax-H3 Ref2VA reference-to-video workflow for ComfyUI.

The workflow supports up to 9 image references, 3 video references, and 3 audio references through the expanded References node, with automatic ref2va routing to the remote vLLM-Omni video API.

Validation

  • python -m pytest tests/e2e/features/comfyui/test_h3_reference_workflow.py -q
  • Validated end-to-end with a real MiniMax-H3 Ref2VA service on 2x NVIDIA A100 80GB GPUs.
  • Generated a 1344x768, 24 FPS, 124-frame video from one image reference.
  • Verified the saved MP4 contains AAC stereo audio at 32 kHz.

Dependencies

The generated workflow screenshot and real-model result will be attached to this PR.

Signed-off-by: Linze-Shi <linzeshi0@gmail.com>
Signed-off-by: Linze-Shi <linzeshi0@gmail.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-15T03:10:14.429321Z b591845 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@LinzeShi
LinzeShi marked this pull request as draft September 15, 2026 03:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5918457df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +159 to +160
4. Match prompt tags such as `<Picture 1>`, `<Video 1>`, and `<Audio 1>` to the
connected references, counting each media type separately and skipping empty slots.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document soundtrack-aware audio tag numbering

When a connected reference video contains audio and a standalone audio_* slot is also connected, this instruction maps the standalone clip to the wrong prompt tag. MiniMax-H3 assigns <Audio 1>, etc. to embedded video soundtracks first, then numbers standalone audio references afterward (pipeline_minimax_h3.py:2463-2470), so a user following this guidance may condition on the wrong audio source. Explain that soundtrack-bearing videos consume audio indices before connected audio slots.

Useful? React with 👍 / 👎.

@LinzeShi

Copy link
Copy Markdown
Contributor Author

Closing this duplicate draft PR; WF-03 is being folded into #7483 so the Node-02 and WF-03 commits can be reviewed together.

@LinzeShi LinzeShi closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant