Skip to content

[Frontend] Add MiniMax-H3 references and Ref2VA workflow - #7483

Merged
princepride merged 4 commits into
vllm-project:mainfrom
LinzeShi:feat/comfyui-h3-reference-inputs
Sep 16, 2026
Merged

[Frontend] Add MiniMax-H3 references and Ref2VA workflow#7483
princepride merged 4 commits into
vllm-project:mainfrom
LinzeShi:feat/comfyui-h3-reference-inputs

Conversation

@LinzeShi

@LinzeShi LinzeShi commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose

Complete NODE-02 and WF-03 from #7380 in one reviewable change.

  • Expand ComfyUI Video References to accept up to 9 images, 3 videos, and 3 audio clips, with at most 12 references and at least one image or video.
  • Preserve numeric slot ordering and existing node ports while sending mixed references through the multipart API.
  • Add the MiniMax-H3 Ref2VA reference-to-video workflow and documentation.

Test plan

python -m pytest tests/e2e/features/comfyui -q
python -m pytest tests/e2e/features/comfyui/test_h3_reference_workflow.py -q

After merging upstream main at 92715f3: 46 tests passed (40 dependency/fork warnings); changed-file pre-commit checks passed. The workflow now uses duration=5.167 seconds for the updated node interface (124 frames at 24 FPS).
9d83e603f9660b8be6bbbc0da287b2bf

image

Real H3 validation

Validated with a real MiniMax-H3 Ref2VA service on 2x NVIDIA A100 80GB GPUs through ComfyUI:

  • One image reference, 1344x768, 24 FPS, 124 frames, 50 sampling points.
  • Generated MP4 output successfully.
  • After the audio-preserving PyAV demux fix, the saved MP4 contains AAC stereo audio at 32 kHz for approximately 5.17 seconds.
  • The attached workflow screenshot shows the generated video preview with audio playback.

The original GPU validation used the single-pass audio fix from #6782 on base e284d90. Current upstream includes an audio-preserving fix via merged #7456; this PR has been updated to that upstream. Real GPU generation has not been rerun after this merge. Mixed-reference and Turbo paths have local checks only, not real H3 generation validation.

@LinzeShi
[Frontend] Complete MiniMax-H3 reference inputs in ComfyUI
15321e1 
Signed-off-by: Linze-Shi <linzeshi0@gmail.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-13T18:08:52.946873Z 15321e1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vllm-omni-review-bot

vllm-omni-review-bot commented Sep 13, 2026

Copy link
Copy Markdown

This PR appears to be related to model: MinimaxH3.

Model owners: @david6666666 @fhfuih @hsliuustc0106

Routing: @david6666666 via semantic router, model owner; @fhfuih via CODEOWNERS; @hsliuustc0106 via CODEOWNERS

@LinzeShi, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer.

Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment.

@LinzeShi

LinzeShi commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

@vllm-omni-review-bot I would like an automated review

@hsliuustc0106 hsliuustc0106 added the high priority high priority issue, needs to be done asap label Sep 13, 2026
@LinzeShi LinzeShi changed the title [Frontend] Complete MiniMax-H3 reference inputs in ComfyUI [Frontend] Complete MiniMax-H3 reference inputs in ComfyUI (NODE-02) Sep 14, 2026
@princepride

princepride commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

@LinzeShi pls add workflow screenshot of new node included. And you also need add the workflow json file in examples.

@princepride

princepride commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

pls refer to this pr: #7456

@LinzeShi

LinzeShi commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@LinzeShi pls add workflow screenshot of new node included. And you also need add the workflow json file in examples.

The screenshot has been added to this PR; the complete workflow JSON and remaining validation will be included in the followup WF-03 commit.

@LinzeShi LinzeShi mentioned this pull request Sep 15, 2026
Closed
@LinzeShi
[Frontend] Add MiniMax-H3 reference-to-video workflow
3afadb6 
Signed-off-by: Linze-Shi <linzeshi0@gmail.com>
@LinzeShi LinzeShi changed the title [Frontend] Complete MiniMax-H3 reference inputs in ComfyUI (NODE-02) [Frontend] Add MiniMax-H3 references and Ref2VA workflow Sep 15, 2026
@LinzeShi
Merge upstream main and adapt Ref2VA workflow duration
aeb0e5d 
Signed-off-by: Linze-Shi <linzeshi0@gmail.com>
@LinzeShi

LinzeShi commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Self-review: checked reference-slot ordering and limits, workflow wiring, and compatibility with the updated duration input. After merging main, all 46 ComfyUI tests and local pre-commit checks passed. The earlier real H3 image-reference run preserved stereo audio with the audio fix applied.

@LinzeShi

LinzeShi commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

@princepride PTAL thx!

@princepride

princepride commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

@LinzeShi Can you help update the screenshot? thank you.

@LinzeShi

LinzeShi commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

@LinzeShi Can you help update the screenshot? thank you.

@princepride Updated workflow screenshot using the latest node interface

princepride
princepride approved these changes Sep 15, 2026
View reviewed changes

@princepride princepride left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread apps/ComfyUI-vLLM-Omni/example_workflows/vLLM-Omni MiniMax-H3 Reference to Video.json Outdated
@princepride princepride added the ready label to trigger buildkite CI label Sep 15, 2026
@princepride
princepride enabled auto-merge (squash) September 15, 2026 08:25
lishunyang12
lishunyang12 reviewed Sep 15, 2026
View reviewed changes
Comment thread apps/ComfyUI-vLLM-Omni/comfyui_vllm_omni/utils/api_client.py Outdated
@LinzeShi
Merge upstream main and share ComfyUI reference limits
c0d7d1d 
Signed-off-by: Linze-Shi <linzeshi0@gmail.com>
auto-merge was automatically disabled September 15, 2026 12:42

Head branch was pushed to by a user without write access

@princepride princepride mentioned this pull request Sep 16, 2026
Open
10 of 17 tasks
@princepride princepride added ready label to trigger buildkite CI and removed ready label to trigger buildkite CI labels Sep 16, 2026
@princepride
princepride enabled auto-merge (squash) September 16, 2026 08:10
@princepride
princepride merged commit e78a5d0 into vllm-project:main Sep 16, 2026
6 of 9 checks passed
@avicii-forever avicii-forever mentioned this pull request Sep 16, 2026
Merged
mlaneuville pushed a commit to mlaneuville/vllm-omni that referenced this pull request Sep 22, 2026
@LinzeShi Matthieu Laneuville
[Frontend] Add MiniMax-H3 references and Ref2VA workflow (vllm-projec…
365751b 
…t#7483)

Signed-off-by: Linze-Shi <linzeshi0@gmail.com>
Signed-off-by: Matthieu Laneuville <matthieu.laneuville@surf.nl>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm-omni that referenced this pull request Sep 25, 2026
@LinzeShi
[Frontend] Add MiniMax-H3 references and Ref2VA workflow (vllm-projec…
c5a0efb 
…t#7483)

Signed-off-by: Linze-Shi <linzeshi0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lishunyang12 lishunyang12 lishunyang12 left review comments
@princepride princepride princepride approved these changes
@alex-jw-brooks alex-jw-brooks Awaiting requested review from alex-jw-brooks alex-jw-brooks is a code owner
@yenuo26 yenuo26 Awaiting requested review from yenuo26 yenuo26 is a code owner
@NickCao NickCao Awaiting requested review from NickCao NickCao is a code owner
@hsliuustc0106 hsliuustc0106 Awaiting requested review from hsliuustc0106 hsliuustc0106 is a code owner
@Gaohan123 Gaohan123 Awaiting requested review from Gaohan123 Gaohan123 is a code owner
@david6666666 david6666666 Awaiting requested review from david6666666 david6666666 is a code owner

Assignees

No one assigned

Labels

high priority high priority issue, needs to be done asap ready label to trigger buildkite CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LinzeShi @vllm-omni-review-bot @princepride @lishunyang12 @hsliuustc0106