[Bugfix] Set separate CFG flag in Helios for CacheDiT#3756
Conversation
Signed-off-by: Alex Brooks <albrooks@redhat.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
could we make this model real-time streaming output? |
|
I am trying to optimizing this model |
|
@hsliuustc0106 Yes, I think Helios should be able to support real-time, at least if it's one request at a time, since it was originally supposed to get up to ~19 FPS on H100! This PR is just a correctness fix though since the outputs get destroyed by not separating CFG correctly |
hsliuustc0106
left a comment
There was a problem hiding this comment.
LGTM - well-justified fix with visual evidence and test coverage.
please check #3737 |
Purpose
Related: #2527
It looks like Helios should have
has_separate_cfg=Truefor Cache-DiT, since we always handle +/- embeds separately, both for standard cfg & cfg zero* (here). You can also see this is the case in the Cache DiT adapter for Helios, here.Currently, the output with cache DiT on using some models, e.g., helios base, will come out fuzzy:
For example, ground truth:
seed_131_gt.mp4
Example with Cache DiT on:
helios_cache_bug.mp4
Result after fix:
post_fix.mp4
Test Plan
Added Helios to explicit checks for has CFG=True (which were previously added for the same issue on Longcat/ltx2 #2860)