[Bugfix] Fix cache dit for Longcat & LTX2#2860
Merged
hsliuustc0106 merged 3 commits intovllm-project:mainfrom Apr 17, 2026
Merged
[Bugfix] Fix cache dit for Longcat & LTX2#2860hsliuustc0106 merged 3 commits intovllm-project:mainfrom
hsliuustc0106 merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Alex Brooks <albrooks@redhat.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
alex-jw-brooks
changed the title
hsliuustc0106
approved these changes
Apr 17, 2026
Collaborator
|
add regression tests please |
Signed-off-by: Alex Brooks <albrooks@redhat.com>
Contributor
Author
|
Thanks @wtomin @hsliuustc0106 - I added some tests to make sure these + wan22 pass |
lvliang-intel
pushed a commit
to lvliang-intel/vllm-omni
that referenced
this pull request
Apr 20, 2026
Signed-off-by: Alex Brooks <albrooks@redhat.com> Co-authored-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
While working on the cache dit backend simplification (#2527), I noticed that the results for LongCat Image and LTX2 have large quality degradation when cache DIT is enabled.
For example, running LongCat Image:
(Top is with cache on, bottom is with cache off).
Similarly, with LTX2:
No cache:
seed_131_no_cache.mp4
With cache:
seed_131_cache.mp4
This is because we don't pass
has_separate_cfg=Truefor these models, which contaminates the results (see the adapter that was originally added for longcat image tocache_dithere).Test Plan
After passing the
has_separate_cfg, the results should not degrade severely.Test Result
Results are much better and more in line with other models.
LongCat image after fix:
LTX2 cached results after fix:
seed_131_fixed.mp4
@wtomin @SamitHuang PTAL, thanks!