-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Misc] Remove Entrypoint Hijack for vLLM / 0.20.0 Changes #3082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
3d9f1d1
6d5cd23
29785d8
70dfcb4
5d1f75c
cee3774
af7aea4
913ef90
baeebb9
db7db82
7a2de36
f98e9c9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,6 @@ classifiers = [ | |
| # Dependencies are now managed dynamically via setup.py based on detected hardware platform. | ||
| # This allows automatic installation of the correct platform-specific dependencies (CUDA/ROCm/CPU/XPU/NPU) | ||
| # without requiring extras like [cuda]. See requirements/ directory for platform-specific dependencies. | ||
| # Note: vllm is intentionally excluded due to entrypoints overwrite issue. | ||
|
|
||
| [project.optional-dependencies] | ||
|
|
||
|
|
@@ -90,7 +89,6 @@ Documentation = "https://vllm-omni.readthedocs.io" | |
| "Bug Tracker" = "https://github.com/vllm-project/vllm-omni/issues" | ||
|
|
||
| [project.scripts] | ||
| vllm = "vllm_omni.entrypoints.cli.main:main" | ||
| vllm-omni = "vllm_omni.entrypoints.cli.main:main" | ||
|
Comment on lines
91
to
92
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Removing the Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a really new problem, but I think we can pin vLLM in requirements now if we want 🙂 maybe would be nice to do that and update the instructions so that it can just be installed directly |
||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,7 +65,7 @@ | |
| from vllm.entrypoints.openai.utils import validate_json_request | ||
| from vllm.entrypoints.pooling.classify.serving import ServingClassification | ||
| from vllm.entrypoints.pooling.embed.serving import ServingEmbedding as OpenAIServingEmbedding | ||
| from vllm.entrypoints.pooling.pooling.serving import OpenAIServingPooling | ||
| from vllm.entrypoints.pooling.pooling.serving import ServingPooling | ||
| from vllm.entrypoints.pooling.score.serving import ServingScores | ||
| from vllm.entrypoints.serve.disagg.serving import ServingTokens | ||
|
|
||
|
|
@@ -810,10 +810,9 @@ async def omni_init_app_state( | |
| else None | ||
| ) | ||
| state.openai_serving_pooling = ( | ||
| OpenAIServingPooling( | ||
| ServingPooling( | ||
| engine_client, | ||
| state.openai_serving_models, | ||
| state.openai_serving_render, | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is unused and that it is being silently absorbed by *args in the superclass constructors, so removing it for clarity
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @tzhouam |
||
| supported_tasks=tuple(supported_tasks), | ||
| request_logger=request_logger, | ||
| chat_template=resolved_chat_template, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the rocm links are actually wrong, should be
https://wheels.vllm.ai/rocm/0.19.0/rocm721(since 0.18 was the last one 700 was prebuilt), so changed it here