[Misc] Remove Entrypoint Hijack for vLLM / 0.20.0 Changes by alex-jw-brooks · Pull Request #3082 · vllm-project/vllm-omni

alex-jw-brooks · 2026-04-23T22:16:58Z

Purpose

Removes entrypoint hijacking for vLLM to prevent installation issues between vLLM / vLLM Omni, e.g., vLLM Omni uninstalling also uninstalling the entrypoint for vLLM, vLLM Omni needing to be installed after vLLM for interception to work correctly, etc.

Should not be merged before vllm-project/vllm#40744, otherwise it'll breakvllm <command> --omni (though vllm-omni will still work)

This should also fix issues like #2850
CC @redwhitecat @hsliuustc0106 @lishunyang12

Signed-off-by: Alex Brooks <albrooks@redhat.com>

lishunyang12 · 2026-04-24T17:37:00Z

Please turn this into ready as upstream pr has been merged.

alex-jw-brooks · 2026-04-24T20:25:30Z

Thanks @lishunyang12! Moved it out of draft, but I think we should wait to merge this until after the Omni 0.19 release, since the upstream change won't be in vLLM until 0.20, otherwise it'll break the entrypoint for 0.19. Changed the title to be safe

Actually since we are going straight to 0.20, should hopefully be fine as the pr on the vLLM side is included in vLLM 0.20 🤞

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d9f1d1727

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-24T20:27:17Z

 [project.scripts]
-vllm = "vllm_omni.entrypoints.cli.main:main"
 vllm-omni = "vllm_omni.entrypoints.cli.main:main"


Add vLLM minimum version when dropping CLI override

Removing the vllm console-script entrypoint makes vllm ... --omni depend entirely on whatever vllm executable is already installed, but this package still does not declare a vllm dependency/version floor in its install metadata. In environments that have an older vLLM (or no vLLM upgrade), users will now hit missing/unknown --omni behavior after upgrading vllm-omni, which is a regression from the previous interception model; please enforce a minimum compatible vLLM version (or fail fast with a clear runtime check).

Useful? React with 👍 / 👎.

Not a really new problem, but I think we can pin vLLM in requirements now if we want 🙂 maybe would be nice to do that and update the instructions so that it can just be installed directly

Signed-off-by: Alex Brooks <albrooks@redhat.com>

alex-jw-brooks · 2026-04-28T21:03:39Z

+If you do not need to modify source code of vLLM, you can directly install the stable 0.20.0 release version of the library

 ```bash
-uv pip install vllm==0.19.0+rocm700 --extra-index-url https://wheels.vllm.ai/rocm/0.19.0/rocm700


Looks like the rocm links are actually wrong, should be https://wheels.vllm.ai/rocm/0.19.0/rocm721 (since 0.18 was the last one 700 was prebuilt), so changed it here

Signed-off-by: Alex Brooks <albrooks@redhat.com>

alex-jw-brooks · 2026-04-28T22:05:08Z

+        ServingPooling(
            engine_client,
            state.openai_serving_models,
-            state.openai_serving_render,


I think this is unused and that it is being silently absorbed by *args in the superclass constructors, so removing it for clarity

cc @tzhouam

Signed-off-by: Alex Brooks <albrooks@redhat.com>

Gaohan123

LGTM. Thanks

…ct#3082) Signed-off-by: Alex Brooks <albrooks@redhat.com> Co-authored-by: SYLAR <125541396+lishunyang12@users.noreply.github.com>

…ct#3082) Signed-off-by: Alex Brooks <albrooks@redhat.com> Co-authored-by: SYLAR <125541396+lishunyang12@users.noreply.github.com> Signed-off-by: sphinxkkkbc <binchengkang8@gmail.com>

…ct#3082) Signed-off-by: Alex Brooks <albrooks@redhat.com> Co-authored-by: SYLAR <125541396+lishunyang12@users.noreply.github.com>

remove entrypoint hijack for vllm

3d9f1d1

Signed-off-by: Alex Brooks <albrooks@redhat.com>

alex-jw-brooks changed the title ~~remove entrypoint hijack for vllm~~ [Misc] Remove Entrypoint Hijack for vLLM Apr 23, 2026

alex-jw-brooks mentioned this pull request Apr 24, 2026

[Frontend] Delegate to vLLM Omni When --omni Passed vllm-project/vllm#40744

Merged

alex-jw-brooks marked this pull request as ready for review April 24, 2026 20:23

alex-jw-brooks requested a review from hsliuustc0106 as a code owner April 24, 2026 20:23

alex-jw-brooks changed the title ~~[Misc] Remove Entrypoint Hijack for vLLM~~ [DO NOT MERGE UNTIL AFTER 0.19] - [Misc] Remove Entrypoint Hijack for vLLM Apr 24, 2026

alex-jw-brooks changed the title ~~[DO NOT MERGE UNTIL AFTER 0.19] - [Misc] Remove Entrypoint Hijack for vLLM~~ [DO NOT MERGE UNTIL AFTER 0.19 RELEASE] - [Misc] Remove Entrypoint Hijack for vLLM Apr 24, 2026

chatgpt-codex-connector Bot reviewed Apr 24, 2026

View reviewed changes

alex-jw-brooks changed the title ~~[DO NOT MERGE UNTIL AFTER 0.19 RELEASE] - [Misc] Remove Entrypoint Hijack for vLLM~~ [Misc] Remove Entrypoint Hijack for vLLM Apr 28, 2026

lishunyang12 added the ready label to trigger buildkite CI label Apr 28, 2026

lishunyang12 and others added 3 commits April 29, 2026 02:59

Merge branch 'main' into remove_hijack

6d5cd23

add note for install

29785d8

Signed-off-by: Alex Brooks <albrooks@redhat.com>

Use vLLM v20

70dfcb4

Signed-off-by: Alex Brooks <albrooks@redhat.com>

alex-jw-brooks force-pushed the remove_hijack branch from 9cf03d0 to 70dfcb4 Compare April 28, 2026 20:57

alex-jw-brooks commented Apr 28, 2026

View reviewed changes

fix device check

5d1f75c

Signed-off-by: Alex Brooks <albrooks@redhat.com>

alex-jw-brooks changed the title ~~[Misc] Remove Entrypoint Hijack for vLLM~~ [Misc] Remove Entrypoint Hijack for vLLM / 0.20.0 Doc Changes Apr 28, 2026

move pooling import

cee3774

Signed-off-by: Alex Brooks <albrooks@redhat.com>

alex-jw-brooks commented Apr 28, 2026

View reviewed changes

alex-jw-brooks added 2 commits April 28, 2026 22:36

fix more imports, bookkeeping signaures

af7aea4

Signed-off-by: Alex Brooks <albrooks@redhat.com>

moe refactor

913ef90

Signed-off-by: Alex Brooks <albrooks@redhat.com>

alex-jw-brooks changed the title ~~[Misc] Remove Entrypoint Hijack for vLLM / 0.20.0 Doc Changes~~ [Misc] Remove Entrypoint Hijack for vLLM / 0.20.0 Changes Apr 28, 2026

hsliuustc0106 removed the ready label to trigger buildkite CI label Apr 29, 2026

yenuo26 linked an issue Apr 29, 2026 that may be closed by this pull request

[Bug]: vllm-omni CLI interception causes benchmark to break without --omni flag #2850

Closed

1 task

alex-jw-brooks force-pushed the remove_hijack branch 2 times, most recently from 26d3b57 to 913ef90 Compare April 29, 2026 22:14

alex-jw-brooks added 2 commits April 29, 2026 16:19

Merge branch 'main' into remove_hijack

baeebb9

Signed-off-by: Alex Brooks <albrooks@redhat.com>

fix editor error

db7db82

Signed-off-by: Alex Brooks <albrooks@redhat.com>

typo

7a2de36

Signed-off-by: Alex Brooks <albrooks@redhat.com>

Gaohan123 added this to the v0.20.0 milestone Apr 30, 2026

Merge branch 'main' into remove_hijack

f98e9c9

Gaohan123 approved these changes Apr 30, 2026

View reviewed changes

Gaohan123 added the ready label to trigger buildkite CI label Apr 30, 2026

Gaohan123 enabled auto-merge (squash) April 30, 2026 11:36

Gaohan123 merged commit bede8e0 into vllm-project:main Apr 30, 2026
7 of 8 checks passed

Yadan-Wei mentioned this pull request May 2, 2026

feat(vllm-omni): bump to v0.20.0 and expand smoke-test matrix aws/deep-learning-containers#6028

Merged

4 tasks

Yadan-Wei mentioned this pull request May 12, 2026

feat(vllm-omni): align chat-omni token counting + 3 new benchmarks + ICE workaround for qwen2.5-omni-3b aws/deep-learning-containers#6079

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Misc] Remove Entrypoint Hijack for vLLM / 0.20.0 Changes#3082

[Misc] Remove Entrypoint Hijack for vLLM / 0.20.0 Changes#3082
Gaohan123 merged 12 commits into
vllm-project:mainfrom
alex-jw-brooks:remove_hijack

alex-jw-brooks commented Apr 23, 2026 •

edited

Loading

Uh oh!

lishunyang12 commented Apr 24, 2026

Uh oh!

alex-jw-brooks commented Apr 24, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 24, 2026

Uh oh!

alex-jw-brooks Apr 24, 2026

Uh oh!

alex-jw-brooks Apr 28, 2026

Uh oh!

alex-jw-brooks Apr 28, 2026 •

edited

Loading

Uh oh!

lishunyang12 Apr 29, 2026

Uh oh!

Gaohan123 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alex-jw-brooks commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Uh oh!

lishunyang12 commented Apr 24, 2026

Uh oh!

alex-jw-brooks commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

alex-jw-brooks Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

alex-jw-brooks Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

alex-jw-brooks Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lishunyang12 Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Gaohan123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alex-jw-brooks commented Apr 23, 2026 •

edited

Loading

alex-jw-brooks commented Apr 24, 2026 •

edited

Loading

alex-jw-brooks Apr 28, 2026 •

edited

Loading