Skip to content

[BugFix][CI]: Fix test_omni_sleep_mode ci bug #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsliuustc0106 merged 1 commit into from
Apr 22, 2026
Merged

[BugFix][CI]: Fix test_omni_sleep_mode ci bug #3010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/offline_inference/test_omni_sleep_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ async def test_multistage_sleep_h100(tp_size):
pass

acks = await engine.sleep(stage_ids=[0, 1], level=2)
assert len(acks) == 2 * tp_size
Copy link
Copy Markdown
Collaborator

@hsliuustc0106 hsliuustc0106 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why previously test can pass?

Copy link
Copy Markdown
Collaborator Author

@princepride princepride Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but now I can't pass in my own branch and latest main branch

Copy link
Copy Markdown
Collaborator Author

@princepride princepride Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's a L4 test and just merged into main

Copy link
Copy Markdown
Collaborator Author

@princepride princepride Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And my own branch have merge-test and nightly-test so I can immediately find this bug

assert len(acks) == 2

await engine.wake_up(stage_ids=[0, 1])
async for _ in engine.generate("verify", sampling_params=[SamplingParams(), sp]):
Expand Down
Loading