[BugFix][CI]: Fix test_omni_sleep_mode ci bug#3010
Merged
hsliuustc0106 merged 1 commit intovllm-project:mainfrom Apr 22, 2026
Merged
[BugFix][CI]: Fix test_omni_sleep_mode ci bug#3010hsliuustc0106 merged 1 commit intovllm-project:mainfrom
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: princepride <wangzhipeng628@gmail.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Collaborator
Author
|
@lishunyang12 @hsliuustc0106 Who can help me approve it. |
| pass | ||
|
|
||
| acks = await engine.sleep(stage_ids=[0, 1], level=2) | ||
| assert len(acks) == 2 * tp_size |
Collaborator
There was a problem hiding this comment.
why previously test can pass?
Collaborator
Author
There was a problem hiding this comment.
I don't know, but now I can't pass in my own branch and latest main branch
Collaborator
Author
There was a problem hiding this comment.
Maybe it's a L4 test and just merged into main
Collaborator
Author
There was a problem hiding this comment.
And my own branch have merge-test and nightly-test so I can immediately find this bug
qinganrice
pushed a commit
to qinganrice/vllm-omni
that referenced
this pull request
Apr 23, 2026
Signed-off-by: princepride <wangzhipeng628@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Related:
#2936
https://buildkite.com/vllm/vllm-omni/builds/7576/steps/canvas?sid=019db2f8-b300-4acb-a9d9-b75a0ae1a896&tab=output
The evidence from the error output confirms this: with
tp_size=2, the ack list contained exactly 2 entries (one for each stage, both withrank: 0). The original assertionlen(acks) == 2 * tp_sizewas 4, but the actual count was 2. The sleep API aggregates across TP ranks and returns one ack per stage.Test Plan
Test Result
Before
After