Skip to content

[BugFix] Remove stage_configs_path validation #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsliuustc0106 merged 2 commits into from
Apr 14, 2026
Merged

[BugFix] Remove stage_configs_path validation #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e228748
Remove stage_configs_path validation
amy-why-3459 Apr 13, 2026
202d06a
Merge branch 'main' into bugfix
amy-why-3459 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions tests/engine/test_arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,6 @@ def test_qwen3_tts_codec_frame_rate_patching():
assert omni_config.codec_frame_rate_hz == 12.3


def test_stage_configs_path_blocks_create_model_config():
"""create_model_config() should raise when stage_configs_path is set."""
args = OmniEngineArgs(stage_configs_path="/some/path.yaml")
with pytest.raises(RuntimeError, match="stage_configs_path"):
args.create_model_config()


def test_from_cli_args_picks_up_stage_configs_path():
"""from_cli_args should pick up stage_configs_path from namespace."""
ns = argparse.Namespace(
Expand Down
5 changes: 0 additions & 5 deletions vllm_omni/engine/arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,6 @@ def create_model_config(self) -> OmniModelConfig:
Returns:
OmniModelConfig instance with all configuration fields set
"""
if self.stage_configs_path is not None:
raise RuntimeError(
"create_model_config() should not be called when stage_configs_path is set. "
"Per-stage model configs are resolved from the stage config YAML."
)
# register omni models to avoid model not found error
self._ensure_omni_models_registered()

Expand Down
Loading