Skip to content

[BugFix] Remove stage_configs_path validation#2741

Merged
hsliuustc0106 merged 2 commits into
vllm-project:mainfrom
amy-why-3459:bugfix
Apr 14, 2026
Merged

[BugFix] Remove stage_configs_path validation#2741
hsliuustc0106 merged 2 commits into
vllm-project:mainfrom
amy-why-3459:bugfix

Conversation

@amy-why-3459
Copy link
Copy Markdown
Contributor

@amy-why-3459 amy-why-3459 commented Apr 13, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Remove the stage_configs_path check to avoid throwing a runtime error during L4 test cases.

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/vllm-omni/vllm_omni/entrypoints/cli/main.py", line 63, in <module>
    main()
  File "/vllm-omni/vllm_omni/entrypoints/cli/main.py", line 57, in main
    args.dispatch_function(args)
  File "/vllm-omni/vllm_omni/entrypoints/cli/serve.py", line 94, in cmd
    run_headless(args)
  File "/vllm-omni/vllm_omni/entrypoints/cli/serve.py", line 552, in run_headless
    vllm_config, executor_class = build_vllm_config(
                                  ^^^^^^^^^^^^^^^^^^
  File "/vllm-omni/vllm_omni/engine/stage_init_utils.py", line 326, in build_vllm_config
    vllm_config = omni_engine_args.create_engine_config(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/vllm/engine/arg_utils.py", line 1549, in create_engine_config
    model_config = self.create_model_config()
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/vllm-omni/vllm_omni/engine/arg_utils.py", line 198, in create_model_config
    raise RuntimeError(
RuntimeError: create_model_config() should not be called when stage_configs_path is set. Per-stage model configs are resolved from the stage config YAML.

Test Plan

pytest -sv test_qwen3_omni_expansion.py -m "advanced_model" --run-level "advanced_model"

Test Result

(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/messages/count_tokens, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /inference/v1/generate, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /scale_elastic_ep, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /is_scaling_elastic_ep, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/chat/completions/render, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/completions/render, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/chat/completions, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/audio/speech, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/audio/speech/batch, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/audio/voices, Methods: GET
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/audio/voices, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/audio/voices/{name}, Methods: DELETE
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /health, Methods: GET
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/models, Methods: GET
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/images/generations, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/images/edits, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/videos, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/videos/sync, Methods: POST
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/videos, Methods: GET
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/videos/{video_id}, Methods: GET
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/videos/{video_id}, Methods: DELETE
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:46] Route: /v1/videos/{video_id}/content, Methods: GET
(APIServer pid=3242233) INFO 04-13 14:51:47 [launcher.py:57] Route: /v1/audio/speech/stream, Endpoint: streaming_speech
OmniServerStageCli ready on 127.0.0.1:35405
OmniServer started successfully

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@amy-why-3459
Copy link
Copy Markdown
Contributor Author

amy-why-3459 commented Apr 13, 2026

@hsliuustc0106
Copy link
Copy Markdown
Collaborator

PR #2741 - [BugFix] Remove stage_configs_path validation

OVERALL: NO BLOCKERS
VERDICT: COMMENT

Correctness: PASS
Reliability: PASS
Breaking: PASS
Tests: PASS (e2e test shows successful start)
Documentation: PASS (inline doc added)
Security: PASS

Summary: Remove stage_configs_path validation to fix L4 tests (RuntimeError: 'model_config'). 0 add, 5 del. Test result shows successful start after fix. No blockers.

Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
Copy link
Copy Markdown
Collaborator

@Gaohan123 Gaohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yenuo26 yenuo26 removed the nightly-test label to trigger buildkite nightly test CI label Apr 14, 2026
Copy link
Copy Markdown
Contributor

@timzsu timzsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test I added is overly aggressive.

@amy-why-3459
Copy link
Copy Markdown
Contributor Author

@hsliuustc0106 @Gaohan123 I think this PR is ready and can be merged. The docs haven't passed testing due to insufficient resources.

@hsliuustc0106 hsliuustc0106 disabled auto-merge April 14, 2026 05:31
@hsliuustc0106 hsliuustc0106 merged commit a5b38b5 into vllm-project:main Apr 14, 2026
7 of 8 checks passed
alex-jw-brooks pushed a commit to alex-jw-brooks/vllm-omni that referenced this pull request Apr 14, 2026
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
alex-jw-brooks pushed a commit to alex-jw-brooks/vllm-omni that referenced this pull request Apr 14, 2026
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
Signed-off-by: Alex Brooks <albrooks@redhat.com>
y123456y78 pushed a commit to y123456y78/vllm-omni that referenced this pull request Apr 15, 2026
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
lvliang-intel pushed a commit to lvliang-intel/vllm-omni that referenced this pull request Apr 20, 2026
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants