[BugFix] Remove stage_configs_path validation#2741
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
PR #2741 - [BugFix] Remove stage_configs_path validation OVERALL: NO BLOCKERS Correctness: PASS Summary: Remove stage_configs_path validation to fix L4 tests (RuntimeError: 'model_config'). 0 add, 5 del. Test result shows successful start after fix. No blockers. |
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
timzsu
left a comment
There was a problem hiding this comment.
LGTM. The test I added is overly aggressive.
|
@hsliuustc0106 @Gaohan123 I think this PR is ready and can be merged. The docs haven't passed testing due to insufficient resources. |
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com> Signed-off-by: Alex Brooks <albrooks@redhat.com>
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Remove the stage_configs_path check to avoid throwing a runtime error during L4 test cases.
Test Plan
pytest -sv test_qwen3_omni_expansion.py -m "advanced_model" --run-level "advanced_model"Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)