Skip to content

[Bugfix] Fix Flux2 Dev Guidance #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamitHuang merged 2 commits into from
Apr 3, 2026
Merged

[Bugfix] Fix Flux2 Dev Guidance #2433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f87813c
fix flux2 guidance
alex-jw-brooks Apr 1, 2026
4d59bc1
use transformer guidance property
alex-jw-brooks Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vllm_omni/diffusion/models/flux2/flux2_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,9 +578,11 @@ def __init__(
guidance_embeds: bool = True,
):
super().__init__()
self.guidance_embeds = guidance_embeds
self.stacked_params_mapping = None
self.out_channels = out_channels or in_channels
self.inner_dim = num_attention_heads * attention_head_dim

self.config = SimpleNamespace(
patch_size=patch_size,
in_channels=in_channels,
Expand Down
8 changes: 7 additions & 1 deletion vllm_omni/diffusion/models/flux2/pipeline_flux2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,7 @@ def forward(
self._attention_kwargs = attention_kwargs
self._current_timestep = None
self._interrupt = False
guidance_tensor = None

# 2. Define call parameters
if prompt is not None and isinstance(prompt, str):
Expand Down Expand Up @@ -1017,6 +1018,11 @@ def forward(
)
self._num_timesteps = len(timesteps)

# handle guidance
if self.transformer.guidance_embeds is not None:
guidance_tensor = torch.full([1], self.guidance_scale, device=device, dtype=torch.float32)
guidance_tensor = guidance_tensor.expand(latents.shape[0])

# 7. Denoising loop
# We set the index here to remove DtoH sync, helpful especially during compilation.
# Check out more details here: https://github.com/huggingface/diffusers/pull/11696
Expand All @@ -1038,7 +1044,7 @@ def forward(
noise_pred = self.transformer(
hidden_states=latent_model_input, # (B, image_seq_len, C)
timestep=timestep / 1000,
guidance=None,
guidance=guidance_tensor,
encoder_hidden_states=prompt_embeds,
txt_ids=text_ids, # B, text_seq_len, 4
img_ids=latent_image_ids, # B, image_seq_len, 4
Expand Down
Loading