[Bugfix] Fix Flux2 Dev Guidance#2433
Merged
SamitHuang merged 2 commits intovllm-project:mainfrom Apr 3, 2026
Merged
Conversation
Signed-off-by: Alex Brooks <albrooks@redhat.com>
lishunyang12
approved these changes
Apr 2, 2026
Collaborator
lishunyang12
left a comment
There was a problem hiding this comment.
Looks good, one nit.
Signed-off-by: Alex Brooks <albrooks@redhat.com>
Collaborator
|
Could you please paste the generated image before and after this PR? |
gcanlin
approved these changes
Apr 3, 2026
Contributor
Author
|
@gcanlin sure, with the example code, no matter what value you pass for guidance, you'll always get the same image since it's unused. With the fix, we should see the guidance affect the result, so giving something like guidance 1.0 should be much worse than guidance 4.0 for example, which is closer to what is recommended for this model. |
linyueqian
pushed a commit
to JuanPZuluaga/vllm-omni
that referenced
this pull request
Apr 3, 2026
Signed-off-by: Alex Brooks <albrooks@redhat.com> Signed-off-by: JuanPZuluaga <juanz9312@gmal.com>
5 tasks
skf-1999
pushed a commit
to Semmer2/vllm-omni
that referenced
this pull request
Apr 7, 2026
Signed-off-by: Alex Brooks <albrooks@redhat.com>
vraiti
pushed a commit
to vraiti/vllm-omni
that referenced
this pull request
Apr 9, 2026
Signed-off-by: Alex Brooks <albrooks@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Flux2 dev is currently not passing guidance through correctly; regardless of the sampling params, the guidance tensor passed to the transformer is hardcoded to
None.This PR creates the guidance tensor and passes it through to the timestep guidance embeddings (original pipeline for reference here).
Test Result
To validate, you can run an example like this:
In the current code, the result will be the same for both since the guidance isn't used, but we should see a poor result for guidance 1.0 and a pretty good one for 4.0.