Skip to content

[GAUDISW-244821] Modify ubi docker to support both internal and external builds#923

Merged
adobrzyn merged 1 commit into
vllm-project:mainfrom
mmuszynskihabana:GAUDISW-244821
Feb 6, 2026
Merged

[GAUDISW-244821] Modify ubi docker to support both internal and external builds#923
adobrzyn merged 1 commit into
vllm-project:mainfrom
mmuszynskihabana:GAUDISW-244821

Conversation

@mmuszynskihabana
Copy link
Copy Markdown
Contributor

@mmuszynskihabana mmuszynskihabana commented Feb 3, 2026

  • parametrize all that's different internally and externally, e.g. locations of RPM packages, pypi indexes
  • add libomp package which is now required during pytorch modules installation
  • add support for RHEL 9.4 builds, handle minor differences between 9.4 and 9.6

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@mmuszynskihabana mmuszynskihabana marked this pull request as ready for review February 3, 2026 18:50
@mmuszynskihabana
Copy link
Copy Markdown
Contributor Author

mmuszynskihabana commented Feb 3, 2026

Following scenarios were tested locally:

  • Docker build -f .cd/Dockerfile.rhel.ubi.vllm . - to check the default values and to use artifacts from vault.habana.ai
  • 1.23.0-695 with internal artifacts, RHEL 9.4 and 9.6
  • latest stable 1.24.0-x build with internal artifacts, RHEL 9.4 and 9.6
  • latest stable 1.24.0-x build with internal artifacts, RHEL 9.4 and 9.6 and with TORCH_TYPE=upstream

@github-actions github-actions Bot mentioned this pull request Feb 3, 2026
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

✅ CI Passed

All checks passed successfully against the following vllm commit:
17b17c068453e6dc6af79240bb94857ae175cc51

@PatrykWo
Copy link
Copy Markdown
Collaborator

PatrykWo commented Feb 4, 2026

@ghandoura please review

@PatrykWo PatrykWo self-assigned this Feb 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

Your branch is behind the base branch. Please merge or rebase to get the latest changes.

ghandoura
ghandoura approved these changes Feb 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ghandoura ghandoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmuszynskihabana
[GAUDISW-244821] Modify ubi docker to support both internal and exter…
5d8ad95 
…nal builds

- parametrize all that's different internally and externally,
  e.g. locations of RPM packages, pypi indexes
- add libomp package which is now required during pytorch modules installation
- add support for RHEL 9.4 builds, handle minor differences between 9.4 and 9.6

Signed-off-by: Michal Muszynski <mmuszynski@habana.ai>
@mmuszynskihabana
Copy link
Copy Markdown
Contributor Author

mmuszynskihabana commented Feb 5, 2026

@mgawarkiewicz-intel please review and let's merge it if there are no objections

PatrykWo
PatrykWo approved these changes Feb 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@PatrykWo PatrykWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested

@adobrzyn adobrzyn merged commit 6d15fdc into vllm-project:main Feb 6, 2026
13 checks passed
slokesha pushed a commit to libinta/vllm-gaudi that referenced this pull request Feb 9, 2026
@mmuszynskihabana @slokesha
[GAUDISW-244821] Modify ubi docker to support both internal and exter…
b73916b 
…nal builds (vllm-project#923)

- parametrize all that's different internally and externally, e.g.
locations of RPM packages, pypi indexes
- add libomp package which is now required during pytorch modules
installation
- add support for RHEL 9.4 builds, handle minor differences between 9.4
and 9.6

Signed-off-by: Michal Muszynski <mmuszynski@habana.ai>
Signed-off-by: slokesha <slokeshappa@habana.ai>
@mmuszynskihabana mmuszynskihabana deleted the GAUDISW-244821 branch February 9, 2026 09:04
PatrykWo pushed a commit that referenced this pull request Feb 26, 2026
@mmuszynskihabana @PatrykWo
[GAUDISW-244821] Modify ubi docker to support both internal and exter…
261aac7 
…nal builds (#923)

- parametrize all that's different internally and externally, e.g.
locations of RPM packages, pypi indexes
- add libomp package which is now required during pytorch modules
installation
- add support for RHEL 9.4 builds, handle minor differences between 9.4
and 9.6

Signed-off-by: Michal Muszynski <mmuszynski@habana.ai>
(cherry picked from commit 6d15fdc)
@PatrykWo PatrykWo mentioned this pull request Feb 26, 2026
Merged
PatrykWo pushed a commit that referenced this pull request Feb 26, 2026
@mmuszynskihabana @PatrykWo
[GAUDISW-244821] Modify ubi docker to support both internal and exter…
35d7d8a 
…nal builds (#923)

- parametrize all that's different internally and externally, e.g.
locations of RPM packages, pypi indexes
- add libomp package which is now required during pytorch modules
installation
- add support for RHEL 9.4 builds, handle minor differences between 9.4
and 9.6

Signed-off-by: Michal Muszynski <mmuszynski@habana.ai>
(cherry picked from commit 6d15fdc)
Signed-off-by: PatrykWo <patryk.wolsza@intel.com>
wpyszka pushed a commit that referenced this pull request Feb 26, 2026
@PatrykWo @mmuszynskihabana
@ghandoura @iboiko-habana @aghandoura @mhelf-intel @michalkuligowski @adobrzyn
[Cherry-pick] Backport RHEL/UBI Dockerfile improvements to releases/v…
12ecf93 
…0.15.1 (#1049)

## Summary

This PR cherry-picks all RHEL/UBI Dockerfile changes merged to `main`
after `releases/v0.15.1` into the v0.15.1 release branch.

## Cherry-picked PRs

| PR | Commit | Description |
|----|--------|-------------|
| [#923](#923) |
`6d15fdc` | [GAUDISW-244821] Modify UBI docker to support both internal
and external builds |
| [#811](#811) |
`a0a0d36` | Fix reported version of vllm |
| [#713](#713) |
`40a425f` | Create UBI based vLLM docker build instructions |
| [#974](#974) |
`6db03ad` | [GADC-941] Add libfdt-devel (new habanalabs-thunk
dependency) to UBI Dockerfile |
| [#971](#971) |
`a3855ac` | [GAUDISW-246357] UBI images improvements |
| [#1008](#1008) |
`b3b2fb3` | Fix Dockerfile for RHEL 9.6 build by updating package
installation order |

## Key changes in `.cd/Dockerfile.rhel.ubi.vllm`

- Added new build args: `OS_VERSION`, `OS_STRING`,
`PT_MODULES_REPO_NAME`, `PT_PACKAGE_NAME_NON_DEFAULT_PYTHON_SUBSTRING`,
`PYPI_INDEX_URL`, `HABANA_RPM_REPO_PATH`
- Support `SYNAPSE_REVISION=latest` (auto-detects newest available
revision)
- Detected Synapse revision stored in `/etc/habanalabs/synapse_revision`
for use across stages
- `dnf install` uses `--allowerasing` throughout;
`openssl-fips-provider-so` removal has `|| true` to support RHEL 9.4
- Added packages: `libomp`, `libjpeg-turbo-devel` (replaces
`libjpeg-devel`), `libfdt-devel`
- `pip` calls use `--no-cache-dir`
- vLLM install: replaced `use_existing_torch.py` with `pip install -r
<(sed '/^torch/d' requirements/build.txt)`
- `pip check` added after installation
- Final stage renamed to `AS vllm-openai`
- `OS_STRING` is now parametric (supports both RHEL 9.4 and 9.6)

---------

Signed-off-by: Michal Muszynski <mmuszynski@habana.ai>
Signed-off-by: PatrykWo <patryk.wolsza@intel.com>
Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com>
Signed-off-by: mhelf-intel <monika.helfer@intel.com>
Signed-off-by: Michal Muszynski <michal.muszynski@intel.com>
Co-authored-by: Michal Muszynski <141021743+mmuszynskihabana@users.noreply.github.com>
Co-authored-by: Adam Ghandoura <adam.ghandoura@intel.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Iryna Boiko <iboiko@habana.ai>
Co-authored-by: aghandoura <adam.ghandoura@gmail.com>
Co-authored-by: mhelf-intel <monika.helfer@intel.com>
Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com>
Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com>
PatrykWo added a commit that referenced this pull request Feb 26, 2026
@PatrykWo @mmuszynskihabana
@ghandoura @iboiko-habana @aghandoura @mhelf-intel @michalkuligowski @adobrzyn
[Cherry-pick] Backport RHEL/UBI Dockerfile improvements to releases/v…
313347f 
…0.15.1 (#1049)

This PR cherry-picks all RHEL/UBI Dockerfile changes merged to `main`
after `releases/v0.15.1` into the v0.15.1 release branch.

| PR | Commit | Description |
|----|--------|-------------|
| [#923](#923) |
`6d15fdc` | [GAUDISW-244821] Modify UBI docker to support both internal
and external builds |
| [#811](#811) |
`a0a0d36` | Fix reported version of vllm |
| [#713](#713) |
`40a425f` | Create UBI based vLLM docker build instructions |
| [#974](#974) |
`6db03ad` | [GADC-941] Add libfdt-devel (new habanalabs-thunk
dependency) to UBI Dockerfile |
| [#971](#971) |
`a3855ac` | [GAUDISW-246357] UBI images improvements |
| [#1008](#1008) |
`b3b2fb3` | Fix Dockerfile for RHEL 9.6 build by updating package
installation order |

- Added new build args: `OS_VERSION`, `OS_STRING`,
`PT_MODULES_REPO_NAME`, `PT_PACKAGE_NAME_NON_DEFAULT_PYTHON_SUBSTRING`,
`PYPI_INDEX_URL`, `HABANA_RPM_REPO_PATH`
- Support `SYNAPSE_REVISION=latest` (auto-detects newest available
revision)
- Detected Synapse revision stored in `/etc/habanalabs/synapse_revision`
for use across stages
- `dnf install` uses `--allowerasing` throughout;
`openssl-fips-provider-so` removal has `|| true` to support RHEL 9.4
- Added packages: `libomp`, `libjpeg-turbo-devel` (replaces
`libjpeg-devel`), `libfdt-devel`
- `pip` calls use `--no-cache-dir`
- vLLM install: replaced `use_existing_torch.py` with `pip install -r
<(sed '/^torch/d' requirements/build.txt)`
- `pip check` added after installation
- Final stage renamed to `AS vllm-openai`
- `OS_STRING` is now parametric (supports both RHEL 9.4 and 9.6)

---------

Signed-off-by: Michal Muszynski <mmuszynski@habana.ai>
Signed-off-by: PatrykWo <patryk.wolsza@intel.com>
Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com>
Signed-off-by: mhelf-intel <monika.helfer@intel.com>
Signed-off-by: Michal Muszynski <michal.muszynski@intel.com>
Co-authored-by: Michal Muszynski <141021743+mmuszynskihabana@users.noreply.github.com>
Co-authored-by: Adam Ghandoura <adam.ghandoura@intel.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Iryna Boiko <iboiko@habana.ai>
Co-authored-by: aghandoura <adam.ghandoura@gmail.com>
Co-authored-by: mhelf-intel <monika.helfer@intel.com>
Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com>
Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com>
@PatrykWo PatrykWo mentioned this pull request Feb 26, 2026
Merged
adobrzyn pushed a commit that referenced this pull request Mar 31, 2026
@mmuszynskihabana @adobrzyn
[GAUDISW-244821] Modify ubi docker to support both internal and exter…
c9ab994 
…nal builds (#923)

- parametrize all that's different internally and externally, e.g.
locations of RPM packages, pypi indexes
- add libomp package which is now required during pytorch modules
installation
- add support for RHEL 9.4 builds, handle minor differences between 9.4
and 9.6

Signed-off-by: Michal Muszynski <mmuszynski@habana.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatrykWo PatrykWo PatrykWo approved these changes

@adobrzyn adobrzyn adobrzyn approved these changes

@xuechendi xuechendi Awaiting requested review from xuechendi xuechendi is a code owner

@mgawarkiewicz-intel mgawarkiewicz-intel Awaiting requested review from mgawarkiewicz-intel mgawarkiewicz-intel is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@iboiko-habana iboiko-habana Awaiting requested review from iboiko-habana iboiko-habana is a code owner

@kamil-kaczor kamil-kaczor Awaiting requested review from kamil-kaczor kamil-kaczor is a code owner

@ksmusz ksmusz Awaiting requested review from ksmusz ksmusz is a code owner

+1 more reviewer

@ghandoura ghandoura ghandoura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PatrykWo PatrykWo

Labels

skip-gaudi-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmuszynskihabana @PatrykWo @ghandoura @adobrzyn