Fix Dockerfile for RHEL 9.6 build by updating package installation order#1008
Merged
Conversation
Signed-off-by: PatrykWo <patryk.wolsza@intel.com>
PatrykWo
requested review from
adobrzyn,
afierka-intel,
iboiko-habana,
mgawarkiewicz-intel,
michalkuligowski and
xuechendi
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical package installation ordering issue in the RHEL 9.6 Dockerfile. The bug caused the build to inadvertently upgrade to RHEL 9.7 because dnf update ran before the versionlock plugin was installed and configured to lock the redhat-release package.
Changes:
- Reordered package installation commands to install versionlock plugin first, apply version locks second, and run system update last
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
ghandoura
approved these changes
Feb 23, 2026
afierka-intel
approved these changes
Feb 23, 2026
PatrykWo
added a commit
that referenced
this pull request
Feb 26, 2026
…der (#1008) Fix the issue is in the first RUN command. The dnf -y update runs before versionlock is installed and applied, so redhat-release gets updated to 9.7 before it can be locked. Signed-off-by: PatrykWo <patryk.wolsza@intel.com> (cherry picked from commit b3b2fb3) Signed-off-by: PatrykWo <patryk.wolsza@intel.com>
wpyszka
pushed a commit
that referenced
this pull request
Feb 26, 2026
…0.15.1 (#1049) ## Summary This PR cherry-picks all RHEL/UBI Dockerfile changes merged to `main` after `releases/v0.15.1` into the v0.15.1 release branch. ## Cherry-picked PRs | PR | Commit | Description | |----|--------|-------------| | [#923](#923) | `6d15fdc` | [GAUDISW-244821] Modify UBI docker to support both internal and external builds | | [#811](#811) | `a0a0d36` | Fix reported version of vllm | | [#713](#713) | `40a425f` | Create UBI based vLLM docker build instructions | | [#974](#974) | `6db03ad` | [GADC-941] Add libfdt-devel (new habanalabs-thunk dependency) to UBI Dockerfile | | [#971](#971) | `a3855ac` | [GAUDISW-246357] UBI images improvements | | [#1008](#1008) | `b3b2fb3` | Fix Dockerfile for RHEL 9.6 build by updating package installation order | ## Key changes in `.cd/Dockerfile.rhel.ubi.vllm` - Added new build args: `OS_VERSION`, `OS_STRING`, `PT_MODULES_REPO_NAME`, `PT_PACKAGE_NAME_NON_DEFAULT_PYTHON_SUBSTRING`, `PYPI_INDEX_URL`, `HABANA_RPM_REPO_PATH` - Support `SYNAPSE_REVISION=latest` (auto-detects newest available revision) - Detected Synapse revision stored in `/etc/habanalabs/synapse_revision` for use across stages - `dnf install` uses `--allowerasing` throughout; `openssl-fips-provider-so` removal has `|| true` to support RHEL 9.4 - Added packages: `libomp`, `libjpeg-turbo-devel` (replaces `libjpeg-devel`), `libfdt-devel` - `pip` calls use `--no-cache-dir` - vLLM install: replaced `use_existing_torch.py` with `pip install -r <(sed '/^torch/d' requirements/build.txt)` - `pip check` added after installation - Final stage renamed to `AS vllm-openai` - `OS_STRING` is now parametric (supports both RHEL 9.4 and 9.6) --------- Signed-off-by: Michal Muszynski <mmuszynski@habana.ai> Signed-off-by: PatrykWo <patryk.wolsza@intel.com> Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com> Signed-off-by: mhelf-intel <monika.helfer@intel.com> Signed-off-by: Michal Muszynski <michal.muszynski@intel.com> Co-authored-by: Michal Muszynski <141021743+mmuszynskihabana@users.noreply.github.com> Co-authored-by: Adam Ghandoura <adam.ghandoura@intel.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Iryna Boiko <iboiko@habana.ai> Co-authored-by: aghandoura <adam.ghandoura@gmail.com> Co-authored-by: mhelf-intel <monika.helfer@intel.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com>
PatrykWo
added a commit
that referenced
this pull request
Feb 26, 2026
…0.15.1 (#1049) This PR cherry-picks all RHEL/UBI Dockerfile changes merged to `main` after `releases/v0.15.1` into the v0.15.1 release branch. | PR | Commit | Description | |----|--------|-------------| | [#923](#923) | `6d15fdc` | [GAUDISW-244821] Modify UBI docker to support both internal and external builds | | [#811](#811) | `a0a0d36` | Fix reported version of vllm | | [#713](#713) | `40a425f` | Create UBI based vLLM docker build instructions | | [#974](#974) | `6db03ad` | [GADC-941] Add libfdt-devel (new habanalabs-thunk dependency) to UBI Dockerfile | | [#971](#971) | `a3855ac` | [GAUDISW-246357] UBI images improvements | | [#1008](#1008) | `b3b2fb3` | Fix Dockerfile for RHEL 9.6 build by updating package installation order | - Added new build args: `OS_VERSION`, `OS_STRING`, `PT_MODULES_REPO_NAME`, `PT_PACKAGE_NAME_NON_DEFAULT_PYTHON_SUBSTRING`, `PYPI_INDEX_URL`, `HABANA_RPM_REPO_PATH` - Support `SYNAPSE_REVISION=latest` (auto-detects newest available revision) - Detected Synapse revision stored in `/etc/habanalabs/synapse_revision` for use across stages - `dnf install` uses `--allowerasing` throughout; `openssl-fips-provider-so` removal has `|| true` to support RHEL 9.4 - Added packages: `libomp`, `libjpeg-turbo-devel` (replaces `libjpeg-devel`), `libfdt-devel` - `pip` calls use `--no-cache-dir` - vLLM install: replaced `use_existing_torch.py` with `pip install -r <(sed '/^torch/d' requirements/build.txt)` - `pip check` added after installation - Final stage renamed to `AS vllm-openai` - `OS_STRING` is now parametric (supports both RHEL 9.4 and 9.6) --------- Signed-off-by: Michal Muszynski <mmuszynski@habana.ai> Signed-off-by: PatrykWo <patryk.wolsza@intel.com> Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com> Signed-off-by: mhelf-intel <monika.helfer@intel.com> Signed-off-by: Michal Muszynski <michal.muszynski@intel.com> Co-authored-by: Michal Muszynski <141021743+mmuszynskihabana@users.noreply.github.com> Co-authored-by: Adam Ghandoura <adam.ghandoura@intel.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Iryna Boiko <iboiko@habana.ai> Co-authored-by: aghandoura <adam.ghandoura@gmail.com> Co-authored-by: mhelf-intel <monika.helfer@intel.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com>
adobrzyn
pushed a commit
that referenced
this pull request
Mar 31, 2026
…der (#1008) Fix the issue is in the first RUN command. The dnf -y update runs before versionlock is installed and applied, so redhat-release gets updated to 9.7 before it can be locked. Signed-off-by: PatrykWo <patryk.wolsza@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue is in the first RUN command. The dnf -y update runs before versionlock is installed and applied, so redhat-release gets updated to 9.7 before it can be locked.