[Doc]Add InternVL3.5 documentation - #9980
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces documentation for the InternVL3.5 multimodal model family. It provides users with necessary environment preparation steps, deployment configurations for both single and multi-NPU setups, and guidance on performing accuracy and performance evaluations within the vLLM-Ascend ecosystem. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces documentation for the InternVL3.5 model family on Ascend NPUs, covering installation, deployment, accuracy evaluation, and performance benchmarking. The review feedback suggests updating the PR title and summary to comply with the repository's style guide, and fixing a tab synchronization conflict where the model selection tab-set incorrectly shares the 'install' sync-group with the installation tab-set.
| @@ -0,0 +1,288 @@ | |||
| # InternVL3.5(InternVL3_5-38B/-241B-A28B) | |||
There was a problem hiding this comment.
Please update the Pull Request title and summary to adhere to the repository's Pull Request Summary Style Guide.
Suggested PR Title:
[Doc][Misc] Add InternVL3.5 documentationSuggested PR Summary:
### What this PR does / why we need it?
This PR adds the documentation for the `InternVL3.5` family of models (`InternVL3_5-38B` and `InternVL3_5-241B-A28B`) on Ascend NPUs. It covers supported features, environment preparation (including Docker container setup), deployment (online serving), accuracy evaluation using `lm_eval`, and performance benchmarking.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
This is a documentation update and does not require code testing.References
- The Pull Request title and summary must follow the format specified in the Pull Request Summary Style Guide. (link)
| :::::{tab-set} | ||
| :sync-group: install |
There was a problem hiding this comment.
The sync-group for the model selection tab-set is set to install, which is the same as the installation tab-set. Since both tab-sets share the same sync-group and some tab-items share the sync key multi, clicking a model tab (e.g., InternVL3_5-241B-A28B) will unexpectedly switch the active tab in the installation section. Please change the sync-group to a different identifier, such as model, to keep these tab-sets independent.
| :::::{tab-set} | |
| :sync-group: install | |
| ::::::{tab-set} | |
| ::sync-group: model |
347a7f2 to
a1d2a57
Compare
Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
| :::: | ||
| ::::: | ||
|
|
||
| If you want to deploy multi-node environment, you need to set up environment on each node. |
There was a problem hiding this comment.
should we add doc for multi-node?
| export IMAGE=quay.io/ascend/vllm-ascend:|vllm_ascend_version| | ||
|
|
||
| docker run --rm \ | ||
| --name $NAME \ |
There was a problem hiding this comment.
it seems like this env is not defined.
| ```shell | ||
| lm_eval \ | ||
| --model vllm-vlm \ | ||
| --model_args pretrained=OpenGVLab/InternVL3_5-38B,max_model_len=8192,gpu_memory_utilization=0.7 \ |
There was a problem hiding this comment.
As an example, take the mmmu_valdataset as a test dataset, and run accuracy evaluation ofInternVL3_5-241B-A28B in offline mode. you shell script is not matched with description.
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
… into main-dsv4 * 'main-dsv4' of https://github.com/chen-commits/vllm-ascend: (35 commits) 测试qwen3.5-122B [BugFix][UT] Fix platform eager mode log assertion (vllm-project#10075) [Misc] Use logger.info_once for enable_npugraph_ex log (vllm-project#9699) [CI] delete DeepSeek-R1-W8A8.yaml update DeepSeek-R1-0528-W8A8-EPLB.yaml (vllm-project#10055) [CI] fix ci error when rebase on latest main (vllm-project#10057) [CI] Upgrade the image version of pr_e2e_comment (vllm-project#10052) [BugFix] Include zero cached prompt token details (vllm-project#9911) [Doc][Misc] Update release notes known issues (vllm-project#10039) [Doc]Update MiniMax-M2.5.md change A2 to single node (vllm-project#9481) [Doc]Add InternVL3.5 documentation (vllm-project#9980) [BugFix]Fix the question that cant find num_kv_head from some model config (vllm-project#10008) [Ascend950][BugFix] Fix MoonViT3dPretrainedModel.to overriding quantized ViT weight dtype (vllm-project#9929) [CI][Test] Optimize selective test routing and CI test stability (vllm-project#9994) [BugFix] fix dsv4 piecewise scenario (vllm-project#10003) [Test][CI] final part for selected test (vllm-project#10017) [Feature] Enable prefix caching with PCP/DCP (vllm-project#9638) [Doc]Update GLM-5 documentation and support matrix (vllm-project#9889) [CI] add MiniMax A2 acc case (vllm-project#9855) [Bugfix] [kimi] upgrade transformers from 5.5.3 to 5.5.4 (vllm-project#9996) [Doc][Model] Add DeepSeek-V4 Flash and Pro documentation (vllm-project#9995) ...
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com> Signed-off-by: calyoung80 <zsucal@hotmail.com> Signed-off-by: BobQiu1981 <qiumingbo81@163.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
Does this PR introduce any user-facing change?
How was this patch tested?
ci test refers to #10002