[CI]add internvl ci test - #10002
Conversation
Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new CI test configurations for the InternVL3.5 model family within the existing nightly testing framework. By adding these YAML configuration files, the project ensures that these specific model variants are correctly validated during automated end-to-end testing cycles. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces nightly single-node end-to-end test configurations for the InternVL3.5-241B-A28B and InternVL3.5-38B models on Ascend NPUs. The review feedback correctly identifies a critical issue in both configuration files where the command-line argument --compilation_config is used with an underscore instead of a hyphen (--compilation-config), which would cause an unrecognized argument error during server startup.
| <<: *envs | ||
| server_cmd: *server_cmd | ||
| server_cmd_extra: | ||
| - "--compilation_config" |
There was a problem hiding this comment.
The command-line argument for compilation configuration in vLLM is --compilation-config (with a hyphen) rather than --compilation_config (with an underscore). Using the underscore version will result in an unrecognized argument error when starting the server.
Suggested PR Title:
[CI][Test][Feature] Add InternVL3.5 CI testsSuggested PR Summary:
### What this PR does / why we need it?
This PR adds end-to-end (e2e) nightly single-node CI test configurations for the InternVL3.5 models, specifically `InternVL3.5-241B-A28B` and `InternVL3.5-38B`. These configurations define the environment variables, server commands, and accuracy benchmarks to ensure the models run correctly and meet accuracy thresholds on Ascend NPUs.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
This patch adds test configuration files (`InternVL3.5-241B-A28B.yaml` and `InternVL3.5-38B.yaml`) to be run as part of the nightly CI suite. - "--compilation-config"References
- The PR Title and PR Summary must follow the specific formats defined in the Repository Style Guide. (link)
| <<: *envs | ||
| server_cmd: *server_cmd | ||
| server_cmd_extra: | ||
| - "--compilation_config" |
There was a problem hiding this comment.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to #10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com> Signed-off-by: calyoung80 <zsucal@hotmail.com> Signed-off-by: BobQiu1981 <qiumingbo81@163.com>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project/vllm-ascend#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project/vllm-ascend#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
### What this PR does / why we need it? Upload doc for InternVL3_5 on Ascend ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ci test refers to vllm-project/vllm-ascend#10002 - vLLM version: v0.20.2 - vLLM main: vllm-project/vllm@9090368 Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com> Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?