Skip to content

[CI]add internvl ci test - #10002

Open
nakairika wants to merge 1 commit into
vllm-project:mainfrom
nakairika:internvl-test
Open

[CI]add internvl ci test#10002
nakairika wants to merge 1 commit into
vllm-project:mainfrom
nakairika:internvl-test

Conversation

@nakairika

@nakairika nakairika commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new CI test configurations for the InternVL3.5 model family within the existing nightly testing framework. By adding these YAML configuration files, the project ensures that these specific model variants are correctly validated during automated end-to-end testing cycles.

Highlights

  • CI Configuration: Added new end-to-end nightly CI test configurations for InternVL3.5-241B-A28B and InternVL3.5-38B models.
  • Test Infrastructure: Defined model-specific environment variables, server commands, and accuracy benchmarks to support automated testing on Ascend hardware.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/schedule_nightly_test_a3.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces nightly single-node end-to-end test configurations for the InternVL3.5-241B-A28B and InternVL3.5-38B models on Ascend NPUs. The review feedback correctly identifies a critical issue in both configuration files where the command-line argument --compilation_config is used with an underscore instead of a hyphen (--compilation-config), which would cause an unrecognized argument error during server startup.

<<: *envs
server_cmd: *server_cmd
server_cmd_extra:
- "--compilation_config"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The command-line argument for compilation configuration in vLLM is --compilation-config (with a hyphen) rather than --compilation_config (with an underscore). Using the underscore version will result in an unrecognized argument error when starting the server.


Suggested PR Title:

[CI][Test][Feature] Add InternVL3.5 CI tests

Suggested PR Summary:

### What this PR does / why we need it?

This PR adds end-to-end (e2e) nightly single-node CI test configurations for the InternVL3.5 models, specifically `InternVL3.5-241B-A28B` and `InternVL3.5-38B`. These configurations define the environment variables, server commands, and accuracy benchmarks to ensure the models run correctly and meet accuracy thresholds on Ascend NPUs.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

This patch adds test configuration files (`InternVL3.5-241B-A28B.yaml` and `InternVL3.5-38B.yaml`) to be run as part of the nightly CI suite.
      - "--compilation-config"
References
  1. The PR Title and PR Summary must follow the specific formats defined in the Repository Style Guide. (link)

<<: *envs
server_cmd: *server_cmd
server_cmd_extra:
- "--compilation_config"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The command-line argument for compilation configuration in vLLM is --compilation-config (with a hyphen) rather than --compilation_config (with an underscore). Using the underscore version will result in an unrecognized argument error when starting the server.

      - "--compilation-config"

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Tflowers-0129 Tflowers-0129 added ready enable e2e test for PR ready-for-test labels Jun 4, 2026
weijinqian0 pushed a commit that referenced this pull request Jun 5, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to #10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
AuroraEmiya pushed a commit to AuroraEmiya/vllm-ascend that referenced this pull request Jun 5, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
calyoung80 pushed a commit to calyoung80/vllm-ascend that referenced this pull request Jun 7, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
Signed-off-by: calyoung80 <zsucal@hotmail.com>
Signed-off-by: BobQiu1981 <qiumingbo81@163.com>
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wangxiyuan wangxiyuan removed the ready enable e2e test for PR label Jun 15, 2026
LostFox11 pushed a commit to LostFox11/vllm-ascend that referenced this pull request Jun 15, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
LostFox11 pushed a commit to LostFox11/vllm-ascend that referenced this pull request Jun 15, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
ader47 pushed a commit to ader47/vllm-ascend that referenced this pull request Jun 18, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
CXY-Katrina pushed a commit to CXY-Katrina/vllm-ascend that referenced this pull request Jun 27, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
HaoxinZong pushed a commit to HaoxinZong/vllm-ascend that referenced this pull request Jun 27, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
xmdhb pushed a commit to vLLM-HUST/vllm-ascend-hust that referenced this pull request Jun 28, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project/vllm-ascend#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
pisceskkk pushed a commit to pisceskkk/vllm-ascend that referenced this pull request Jun 29, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
xmdhb pushed a commit to vLLM-HUST/vllm-ascend-hust that referenced this pull request Jul 2, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project/vllm-ascend#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
xqchen7 pushed a commit to nv-action/vllm-benchmarks that referenced this pull request Jul 15, 2026
### What this PR does / why we need it?
Upload doc for InternVL3_5 on Ascend
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
ci test refers to vllm-project/vllm-ascend#10002

- vLLM version: v0.20.2
- vLLM main:
vllm-project/vllm@9090368

Signed-off-by: nakairika <35144242+nakairika@users.noreply.github.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants