Skip to content

[BugFix][310p][0.18.0] remove triton-ascend's installation of 310p - #8295

Closed
Tflowers-0129 wants to merge 1 commit into
vllm-project:releases/v0.18.0from
Tflowers-0129:v0.18.0
Closed

Tflowers-0129 wants to merge 1 commit into
vllm-project:releases/v0.18.0from
Tflowers-0129:v0.18.0

Conversation

@Tflowers-0129

@Tflowers-0129 Tflowers-0129 commented Apr 15, 2026 •

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it?

The triton-ascend dependency has been removed from the pyproject.toml build requirements to prevent its installation on 310p, because the triton-ascend cannot use by 310p, when it install by default cause some error in spec and fusion pass.
cherrypick from #7238

Does this PR introduce any user-facing change?

NO

How was this patch tested?

the ci and local tests

  • vLLM version: v0.18.0

Signed-off-by: Tflowers-0129 <2906339855@qq.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues on 310p hardware by ensuring that the triton-ascend dependency is not installed in environments where it is unsupported. By moving the dependency management logic into the setup script, the build process now intelligently filters out this package based on the detected SOC version, preventing errors during compilation and fusion passes.

Highlights

  • Dependency Removal: Removed triton-ascend from the build requirements in pyproject.toml to prevent installation issues on 310p hardware.
  • Conditional Installation: Updated setup.py to dynamically skip the installation of triton-ascend when the SOC_VERSION environment variable indicates an ascend310p target.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build system to conditionally exclude the triton-ascend dependency for Ascend 310P SOC versions. It removes the static requirement from pyproject.toml and adds dynamic filtering logic in setup.py based on the SOC_VERSION environment variable. I have no feedback to provide. Suggested PR Title: [Ops][Misc] Conditionally skip triton-ascend dependency for Ascend 310P Suggested PR Summary: ### What this PR does / why we need it? This PR ensures that triton-ascend is not installed on Ascend 310P hardware by moving the dependency management from pyproject.toml to a dynamic check in setup.py. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant