[BugFix][310p][0.18.0] remove triton-ascend's installation of 310p - #8295
Tflowers-0129 wants to merge 1 commit into
Conversation
Signed-off-by: Tflowers-0129 <2906339855@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility issues on 310p hardware by ensuring that the triton-ascend dependency is not installed in environments where it is unsupported. By moving the dependency management logic into the setup script, the build process now intelligently filters out this package based on the detected SOC version, preventing errors during compilation and fusion passes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the build system to conditionally exclude the triton-ascend dependency for Ascend 310P SOC versions. It removes the static requirement from pyproject.toml and adds dynamic filtering logic in setup.py based on the SOC_VERSION environment variable. I have no feedback to provide. Suggested PR Title: [Ops][Misc] Conditionally skip triton-ascend dependency for Ascend 310P Suggested PR Summary: ### What this PR does / why we need it? This PR ensures that triton-ascend is not installed on Ascend 310P hardware by moving the dependency management from pyproject.toml to a dynamic check in setup.py. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI passed.
What this PR does / why we need it?
The triton-ascend dependency has been removed from the pyproject.toml build requirements to prevent its installation on 310p, because the triton-ascend cannot use by 310p, when it install by default cause some error in spec and fusion pass.
cherrypick from #7238
Does this PR introduce any user-facing change?
NO
How was this patch tested?
the ci and local tests