[BugFix][310P] remove triton-ascend's installation of 310p devices - #7238
Tflowers-0129 wants to merge 6 commits into
Conversation
Signed-off-by: Tflowers-0129 <2906339855@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's dependency management by introducing conditional logic for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request correctly removes the triton-ascend dependency for 310P devices by updating pyproject.toml and adding dynamic filtering in setup.py. This prevents installation failures on 310P hardware. One improvement is suggested in setup.py to use the packaging library for more robust parsing of requirement strings.
The pull request title and description do not follow the repository's style guide. Here are the suggested updates:
Suggested PR Title:
[CI][BugFix] Skip triton-ascend installation on 310P devicesSuggested PR Summary:
### What this PR does / why we need it?
This pull request modifies the package installation process to conditionally exclude the `triton-ascend` dependency when building for Ascend 310P devices. The `triton-ascend` package is not supported on 310P, and its inclusion causes installation failures.
Changes include:
- Removing `triton-ascend` from the static `build-system.requires` list in `pyproject.toml`.
- Updating `setup.py` to dynamically parse `requirements.txt` and filter out `triton-ascend` if the `SOC_VERSION` environment variable indicates a 310P device.
This change ensures that the project can be successfully built and installed on environments with Ascend 310P hardware.
### Does this PR introduce _any_ user-facing change?
No, this change only affects the build and installation process and does not introduce any user-facing changes to the library's API or behavior.
### How was this patch tested?
The patch was tested by building the package in an environment simulating an Ascend 310P device (by setting the `SOC_VERSION` environment variable). The build logs were checked to confirm that the `triton-ascend` package was correctly skipped during installation.|
310p的dockerfile文件中的triton ascend也应该移除吧 |
感谢,我去看看 |
Signed-off-by: Tflowers-0129 <2906339855@qq.com>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
no need |
What this PR does / why we need it?
The triton-ascend dependency has been removed from the pyproject.toml build requirements to prevent its installation on 310p, because the triton-ascend cannot use by 310p, when it install by default cause some error in spec and fusion pass.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
the ci and local tests