lower log level in PD Disaggregation - #7589
Conversation
Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses excessive logging by downgrading a specific log message from INFO to DEBUG. This change aims to reduce noise in the logs, making it easier to identify more critical information without affecting the functionality or behavior of the system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
| params = request.kv_transfer_params | ||
| do_virtual = params.get("do_virtual") | ||
| logger.debug( | ||
| "MooncakeLayerwiseConnector update_state_after_alloc: num_external_tokens=%s, kv_transfer_params=%s", |
There was a problem hiding this comment.
Do not delete the params parameter.
Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
### What this PR does / why we need it? This log is printed too frequently and unecessary, Thus lowering its level from INFO to DEBUG. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@ed359c4 --------- Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
…to qwen3next_graph * 'main' of https://github.com/vllm-project/vllm-ascend: (94 commits) [bugfix] Fixed the error issue when overlaying MTP and full decode on DSV3.1 C8. (vllm-project#7571) [eagle3][pcp] fix acceptance rate for eagle3 and pcp enabled (vllm-project#7549) [bugfix][CI] fix '_OpNamespace' 'vllm' object has no attribute 'qkv_rmsnorm_rope' (vllm-project#7620) [Nightly] Nightly pre-build image (vllm-project#7388) [Bugfix]Fix deepseek 3.2 C8 precision by rotary tensor (vllm-project#7537) adapt to main2main for model runner v2 (vllm-project#7578) [Patch] Fix balance scheduling (vllm-project#7611) [310P]fused recurrent gated delta rule pytorch core and ut (vllm-project#7398) [CI] refine issue triage rules, wan regex and update stale setting (vllm-project#7531) [Lint]Add lint hooks for clang-format, shellcheck, forbidden imports, and boolean context manager checks (vllm-project#7511) [doc] add enable_sparse_c8 option in configuration options (vllm-project#7600) lower log level in PD Disaggregation (vllm-project#7589) [model_runner_v2]:optimize the performance of the _compute_slot_mappings_kernel (vllm-project#7575) [Feat][SP] Suport SP for VL MoE models (vllm-project#7044) Fix Qwen3Next CI Config (vllm-project#7561) [Feat] Add npugraph_ex enablement logging (vllm-project#7574) [UT] Align input arguments with Ascend(Yarn)RotaryEmbedding with vLLM and add ut (vllm-project#7358) [P/D] Check wildcard address for layerwise connector (vllm-project#7389) [P/D] [Bugfix] fix mooncake layerconnector dead when update_decoder_info fail (vllm-project#7514) [BugFix][P/D] fix padding error on FullGraph mode && fix layerwise connector mamba accuracy (vllm-project#7506) ...
### What this PR does / why we need it? This log is printed too frequently and unecessary, Thus lowering its level from INFO to DEBUG. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@ed359c4 --------- Signed-off-by: zouyida2052 <zouyida2002@gmail.com> Signed-off-by: Yang Yuxi <907276627@qq.com>
### What this PR does / why we need it? This log is printed too frequently and unecessary, Thus lowering its level from INFO to DEBUG. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@ed359c4 --------- Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
### What this PR does / why we need it? This log is printed too frequently and unecessary, Thus lowering its level from INFO to DEBUG. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@ed359c4 --------- Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
### What this PR does / why we need it? This log is printed too frequently and unecessary, Thus lowering its level from INFO to DEBUG. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@ed359c4 --------- Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
### What this PR does / why we need it? This log is printed too frequently and unecessary, Thus lowering its level from INFO to DEBUG. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@ed359c4 --------- Signed-off-by: zouyida2052 <zouyida2002@gmail.com> Signed-off-by: nanxing <1014662416@qq.com>
### What this PR does / why we need it? This log is printed too frequently and unecessary, Thus lowering its level from INFO to DEBUG. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@ed359c4 --------- Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
### What this PR does / why we need it? This log is printed too frequently and unecessary, Thus lowering its level from INFO to DEBUG. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@ed359c4 --------- Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
What this PR does / why we need it?
This log is printed too frequently and unecessary, Thus lowering its level from INFO to DEBUG.
Does this PR introduce any user-facing change?
no
How was this patch tested?