[doc] Upload doc for qwen3.5-27B and qwen3.5-397B-A17B on Ascend#7313
[doc] Upload doc for qwen3.5-27B and qwen3.5-397B-A17B on Ascend#7313MengqingCao merged 7 commits intovllm-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the project's support for Qwen3.5 models on Ascend hardware by providing detailed user documentation and corresponding end-to-end tests. The changes enable users to effectively deploy, verify, and evaluate both the Qwen3.5-27B and Qwen3.5-397B-A17B models, enhancing the platform's utility for AI inference on specialized hardware. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: pppeng <zepengliu912@qq.com>
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the Qwen3.5-27B and Qwen3.5-397B-A17B models, along with new end-to-end tests. The documentation is a valuable addition, but I've found a few issues in the provided shell commands and some inconsistencies that could lead to user confusion or errors. I've left specific comments to address these points. The new tests seem correct and follow existing patterns.
| --no-enable-prefix-caching \ | ||
| --speculative_config '{"method": "qwen3_5_mtp", "num_speculative_tokens": 3, "enforce_eager": true}' \ | ||
| --compilation-config '{"cudagraph_mode":"FULL_DECODE_ONLY"}' \ | ||
| --additional-config '{"enable_cpu_binding":true}' |
There was a problem hiding this comment.
The vllm serve command is syntactically incorrect. This line is missing a trailing \ to continue the command on the next line. This will cause the --async-scheduling argument on the next line to be executed as a separate command, which is not the intention.
| --additional-config '{"enable_cpu_binding":true}' | |
| --additional-config '{"enable_cpu_binding":true}' \ |
|
|
||
| The parameters are explained as follows: | ||
|
|
||
| - `--data-parallel-size` 1 and `--tensor-parallel-size` 16 are common settings for data parallelism (DP) and tensor parallelism (TP) sizes. |
There was a problem hiding this comment.
The explanation for --tensor-parallel-size states that 16 is a common setting, but the example script on line 109 uses a value of 2. This discrepancy can be confusing for users. Please either update the example to use 16 or adjust the explanation to reflect the example's value and provide context for when to use different values.
| --no-enable-prefix-caching \ | ||
| --speculative_config '{"method": "qwen3_5_mtp", "num_speculative_tokens": 3, "enforce_eager": true}' \ | ||
| --compilation-config '{"cudagraph_mode":"FULL_DECODE_ONLY"}' \ | ||
| --additional-config '{"enable_cpu_binding":true, "multistream_overlap_shared_expert": true}' |
There was a problem hiding this comment.
The vllm serve command is syntactically incorrect. This line is missing a trailing \ to continue the command on the next line. This will cause the --async-scheduling argument on the next line to be executed as a separate command, which is not the intention.
| --additional-config '{"enable_cpu_binding":true, "multistream_overlap_shared_expert": true}' | |
| --additional-config '{"enable_cpu_binding":true, "multistream_overlap_shared_expert": true}' \ |
| --data-parallel-rpc-port 13389 \ | ||
| --seed 1024 \ | ||
| --tensor-parallel-size 8 \ | ||
| --served-model-name qwen3 \ |
Signed-off-by: pppeng <zepengliu912@qq.com>
Signed-off-by: pppeng <60355449+ppppeng@users.noreply.github.com>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
/approve |
| - (2) Decode requests are prioritized for scheduling, and prefill requests are scheduled only if there is available capacity. | ||
| - Generally, if `--max-num-batched-tokens` is set to a larger value, the overall latency will be lower, but the pressure on GPU memory (activation value usage) will be greater. | ||
| - `--gpu-memory-utilization` represents the proportion of HBM that vLLM will use for actual inference. Its essential function is to calculate the available kv_cache size. During the warm-up phase (referred to as profile run in vLLM), vLLM records the peak GPU memory usage during an inference process with an input size of `--max-num-batched-tokens`. The available kv_cache size is then calculated as: `--gpu-memory-utilization` * HBM size - peak GPU memory usage. Therefore, the larger the value of `--gpu-memory-utilization`, the more kv_cache can be used. However, since the GPU memory usage during the warm-up phase may differ from that during actual inference (e.g., due to uneven EP load), setting `--gpu-memory-utilization` too high may lead to OOM (Out of Memory) issues during actual inference. The default value is `0.9`. | ||
| - `--no-enable-prefix-caching` indicates that prefix caching is disabled. To enable it, remove this option. |
There was a problem hiding this comment.
Actually we also need to set --mamba-cache-mode align to enable prefix caching now, this comment will confuse users
There was a problem hiding this comment.
BTW, I think we can add a script to illustrate how to run qwen3.5 with prefix caching
There was a problem hiding this comment.
I have add comments to prefixcache
Signed-off-by: pppeng <zepengliu912@qq.com>
…scend into qwen3next_graph * 'qwen3next_graph' of https://github.com/845473182/vllm-ascend: (62 commits) [doc] Refresh the documentation for DeepSeek-V3.2 (vllm-project#7403) [bugfix][accuracy] Fix ds indexer accuracy problem caused by k rope (vllm-project#7341) [P/D] LayerwiseConnector supports the virtual push functionality on node D. (vllm-project#7361) [CI] Add PAT_TOKEN when checkout (vllm-project#7400) [main2main] upgrade vllm to 0308 (vllm-project#7213) [CI] add scheduled stale issue management (vllm-project#7354) [CI] expand issue labeler rules for feature/model triage (vllm-project#7356) [Bugfix] Assertion error when decode prefix cache fully hits (vllm-project#7236) [doc] Refresh the documentation for GLM-4.7 (vllm-project#7292) [BugFix]A2 MOE method&& layerwise MTP bugfix && Mamba gdn_metadata bugfix (vllm-project#7364) [doc] Upload doc for qwen3.5-27B and qwen3.5-397B-A17B on Ascend (vllm-project#7313) [bugfix]Enable dispatch_ffn_combine feature for qwen3.5 (vllm-project#7066) [bugfix] fix unzip file path for fia operator (vllm-project#7367) [Perf] Optimize bias handling in AscendRMSNorm (vllm-project#7226) [eagle3][pcp] fix bug for eagle3 and cp enable (vllm-project#7309) [Bugfix] fix TransposeKvCacheByBlock op error report in plog (vllm-project#7235) [Feature]Supports DSv3.1 PD separation and C8 quantization (vllm-project#7222) [main][bugfix] Fixed the problem that eagle3 will crash in FULL_DECODE_ONLY (vllm-project#7290) [xlite][Bugfix] Support mrope and deepstack features in xlite backend (vllm-project#7295) [model_runner_v2]optimize the performance of the _topk_log_softmax_kernel (vllm-project#7221) ...
…m-project#7313) ### What this PR does / why we need it? Upload doc for qwen3.5-27B and qwen3.5-397B-A17B on Ascend Base on vllm-ascend:v0.17.0rc1 - vLLM version: v0.17.0 - vLLM main: vllm-project/vllm@4034c3d --------- Signed-off-by: pppeng <zepengliu912@qq.com> Signed-off-by: pppeng <60355449+ppppeng@users.noreply.github.com>
…m-project#7313) ### What this PR does / why we need it? Upload doc for qwen3.5-27B and qwen3.5-397B-A17B on Ascend Base on vllm-ascend:v0.17.0rc1 - vLLM version: v0.17.0 - vLLM main: vllm-project/vllm@4034c3d --------- Signed-off-by: pppeng <zepengliu912@qq.com> Signed-off-by: pppeng <60355449+ppppeng@users.noreply.github.com>
…m-project#7313) ### What this PR does / why we need it? Upload doc for qwen3.5-27B and qwen3.5-397B-A17B on Ascend Base on vllm-ascend:v0.17.0rc1 - vLLM version: v0.17.0 - vLLM main: vllm-project/vllm@4034c3d --------- Signed-off-by: pppeng <zepengliu912@qq.com> Signed-off-by: pppeng <60355449+ppppeng@users.noreply.github.com>
What this PR does / why we need it?
Upload doc for qwen3.5-27B and qwen3.5-397B-A17B on Ascend
Base on vllm-ascend:v0.17.0rc1
Does this PR introduce any user-facing change?
How was this patch tested?