[Bugfix] fix TransposeKvCacheByBlock op error report in plog#7235
[Bugfix] fix TransposeKvCacheByBlock op error report in plog#7235LCAIZJ merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: lidenghui <lidenghui1110@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes an error log during vLLM startup related to the TransposeKvCacheByBlock operation. The fix involves changing the operator definition for the blockIDs input. My review includes a suggestion to add a code comment to explain this non-obvious change, improving future maintainability.
In addition, I've updated the PR title and summary to better align with the repository's style guide.
Suggested PR Title:
[Ops][BugFix] Fix TransposeKvCacheByBlock op error report in plogSuggested PR Summary:
### What this PR does / why we need it?
<!--
- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR.
- Please clarify why the changes are needed. For instance, the use case and bug description.
- Fixes #7201
-->
This PR addresses an issue where `TransposeKvCacheByBlock` operation-related errors appear in the `plog` during vLLM startup, as reported in #7201. Although these errors do not affect vLLM's runtime, they can be confusing during debugging.
The fix aligns the `blockIDs` input definition with other inputs in the operator by:
- Using `DataType` instead of `DataTypeList`.
- Duplicating the type and format specifiers to match the count used by other dynamic inputs (`KCache`, `VCache`).
This resolves the error messages logged at startup.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as API, interface or other behavior changes.
Documentation-only updates are not considered user-facing changes.
-->
No.
### How was this patch tested?
<!--
CI passed with new added/existing test.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
The change was validated by observing the absence of the `TransposeKvCacheByBlock` error in the `plog` after applying the fix. Existing CI tests continue to pass.| .DataType({ge::DT_INT64, ge::DT_INT64}) | ||
| .Format({ge::FORMAT_ND, ge::FORMAT_ND}) | ||
| .UnknownShapeFormat({ge::FORMAT_ND, ge::FORMAT_ND}); |
There was a problem hiding this comment.
This change appears to be a workaround for a framework requirement where all input definitions in an operator must specify the same number of data types and formats, even for REQUIRED inputs that only support a single type. While this fixes the issue, the duplicated type ge::DT_INT64 is not intuitive and could be mistaken for a bug by future developers. To improve maintainability and prevent this fix from being accidentally reverted, please add a comment explaining why this duplication is necessary.
// NOTE: The number of types and formats must match other dynamic inputs
// in this op definition, even though this input is required and only supports one type.
.DataType({ge::DT_INT64, ge::DT_INT64})
.Format({ge::FORMAT_ND, ge::FORMAT_ND})
.UnknownShapeFormat({ge::FORMAT_ND, ge::FORMAT_ND})|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
…oject#7235) ### What this PR does / why we need it? As issue vllm-project#7201 reported, there are some TransposeKvCacheByBlock operation related ERRORs in plog when vllm launching, though it doesn't influence the running of vllm, but ERRORs will be very confused in debug, this PR fixed the problem as suggested. ### Does this PR introduce _any_ user-facing change? no. ### How was this patch tested? - vLLM version: v0.17.0 - vLLM main: vllm-project/vllm@4034c3d Signed-off-by: lidenghui <lidenghui1110@gmail.com>
…oject#7235) ### What this PR does / why we need it? As issue vllm-project#7201 reported, there are some TransposeKvCacheByBlock operation related ERRORs in plog when vllm launching, though it doesn't influence the running of vllm, but ERRORs will be very confused in debug, this PR fixed the problem as suggested. ### Does this PR introduce _any_ user-facing change? no. ### How was this patch tested? - vLLM version: v0.17.0 - vLLM main: vllm-project/vllm@4034c3d Signed-off-by: lidenghui <lidenghui1110@gmail.com> Signed-off-by: xutianyi <xutianyi5@huawei.com>
…scend into qwen3next_graph * 'qwen3next_graph' of https://github.com/845473182/vllm-ascend: (62 commits) [doc] Refresh the documentation for DeepSeek-V3.2 (vllm-project#7403) [bugfix][accuracy] Fix ds indexer accuracy problem caused by k rope (vllm-project#7341) [P/D] LayerwiseConnector supports the virtual push functionality on node D. (vllm-project#7361) [CI] Add PAT_TOKEN when checkout (vllm-project#7400) [main2main] upgrade vllm to 0308 (vllm-project#7213) [CI] add scheduled stale issue management (vllm-project#7354) [CI] expand issue labeler rules for feature/model triage (vllm-project#7356) [Bugfix] Assertion error when decode prefix cache fully hits (vllm-project#7236) [doc] Refresh the documentation for GLM-4.7 (vllm-project#7292) [BugFix]A2 MOE method&& layerwise MTP bugfix && Mamba gdn_metadata bugfix (vllm-project#7364) [doc] Upload doc for qwen3.5-27B and qwen3.5-397B-A17B on Ascend (vllm-project#7313) [bugfix]Enable dispatch_ffn_combine feature for qwen3.5 (vllm-project#7066) [bugfix] fix unzip file path for fia operator (vllm-project#7367) [Perf] Optimize bias handling in AscendRMSNorm (vllm-project#7226) [eagle3][pcp] fix bug for eagle3 and cp enable (vllm-project#7309) [Bugfix] fix TransposeKvCacheByBlock op error report in plog (vllm-project#7235) [Feature]Supports DSv3.1 PD separation and C8 quantization (vllm-project#7222) [main][bugfix] Fixed the problem that eagle3 will crash in FULL_DECODE_ONLY (vllm-project#7290) [xlite][Bugfix] Support mrope and deepstack features in xlite backend (vllm-project#7295) [model_runner_v2]optimize the performance of the _topk_log_softmax_kernel (vllm-project#7221) ...
### What this PR does / why we need it? Documented an issue in the 2-node PD mixed deployment scenario where inference may hang when concurrency exceeds 8.(GLM5) Noted that the issue has been fixed in PR: - #7235 - #7290. --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: Mengqing Cao <cmq0113@163.com> Co-authored-by: Mengqing Cao <cmq0113@163.com>
…roject#7436) ### What this PR does / why we need it? Documented an issue in the 2-node PD mixed deployment scenario where inference may hang when concurrency exceeds 8.(GLM5) Noted that the issue has been fixed in PR: - vllm-project#7235 - vllm-project#7290. --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: Mengqing Cao <cmq0113@163.com> Co-authored-by: Mengqing Cao <cmq0113@163.com>
…roject#7436) ### What this PR does / why we need it? Documented an issue in the 2-node PD mixed deployment scenario where inference may hang when concurrency exceeds 8.(GLM5) Noted that the issue has been fixed in PR: - vllm-project#7235 - vllm-project#7290. --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: Mengqing Cao <cmq0113@163.com> Co-authored-by: Mengqing Cao <cmq0113@163.com>
…oject#7235) ### What this PR does / why we need it? As issue vllm-project#7201 reported, there are some TransposeKvCacheByBlock operation related ERRORs in plog when vllm launching, though it doesn't influence the running of vllm, but ERRORs will be very confused in debug, this PR fixed the problem as suggested. ### Does this PR introduce _any_ user-facing change? no. ### How was this patch tested? - vLLM version: v0.17.0 - vLLM main: vllm-project/vllm@4034c3d Signed-off-by: lidenghui <lidenghui1110@gmail.com>
…roject#7436) ### What this PR does / why we need it? Documented an issue in the 2-node PD mixed deployment scenario where inference may hang when concurrency exceeds 8.(GLM5) Noted that the issue has been fixed in PR: - vllm-project#7235 - vllm-project#7290. --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: Mengqing Cao <cmq0113@163.com> Co-authored-by: Mengqing Cao <cmq0113@163.com>
What this PR does / why we need it?
As issue #7201 reported, there are some TransposeKvCacheByBlock operation related ERRORs in plog when vllm launching, though it doesn't influence the running of vllm, but ERRORs will be very confused in debug, this PR fixed the problem as suggested.
Does this PR introduce any user-facing change?
no.
How was this patch tested?