Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ async def test_models(model: str, tp_size: int, dp_size: int) -> None:
"VLLM_ASCEND_ENABLE_MLAPO": "1",
"PYTORCH_NPU_ALLOC_CONF": "expandable_segments:True",
"VLLM_ASCEND_ENABLE_FLASHCOMM1": "1",
"VLLM_ENGINE_READY_TIMEOUT_S": "1800"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The timeout value 1800 is hardcoded. It's better to define it as a constant with a descriptive name at the top of the file or in a shared configuration module. This improves readability and makes it easier to manage in the future.

}

server_args = [
Expand Down
Loading