[CI] nightly test timeout#6912
Conversation
Signed-off-by: guozr <guozr1997@hotmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of nightly end-to-end tests by explicitly setting a longer timeout for the VLLM engine's readiness. This change addresses potential issues where the engine might take an extended period to initialize, leading to test failures, and ensures the CI pipeline can accommodate such startup times. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the engine ready timeout for a nightly test to prevent it from failing. While the change is straightforward, the hardcoded timeout value should be defined as a constant for better maintainability and readability.
| "VLLM_ASCEND_ENABLE_MLAPO": "1", | ||
| "PYTORCH_NPU_ALLOC_CONF": "expandable_segments:True", | ||
| "VLLM_ASCEND_ENABLE_FLASHCOMM1": "1", | ||
| "VLLM_ENGINE_READY_TIMEOUT_S": "1800" |
There was a problem hiding this comment.
The timeout value 1800 is hardcoded. It's better to define it as a constant with a descriptive name at the top of the file or in a shared configuration module. This improves readability and makes it easier to manage in the future.
…to qwen3next_graph * 'main' of https://github.com/vllm-project/vllm-ascend: (40 commits) [Feature] Add docs of batch invariance and make some extra operators patch (vllm-project#6910) [bugfix]Qwen2.5VL accurate question (vllm-project#6975) [CI] Add DeepSeek-V3.2 large EP nightly ci (vllm-project#6378) [Ops][BugFix] Fix RoPE shape mismatch for mtp models with flashcomm v1 enabled (vllm-project#6939) [bugfix]fix file not found error in nightly of single-node (vllm-project#6976) [Bugfix] Fix the acceptance rates dorp issue when applying eagle3 to QuaRot model (vllm-project#6914) [CI] Enable auto upgrade e2e estimated time for auto-partition suites (vllm-project#6840) [Doc][Misc] Fix msprobe_guide.md documentation issues (vllm-project#6965) [Nightly][Refactor]Migrate nightly single-node model tests from `.py` to `.yaml` (vllm-project#6503) [BugFix] Improve GDN layer detection for multimodal models (vllm-project#6941) [feat]ds3.2 pcp support mtp and chunkprefill (vllm-project#6917) [CPU binding] Implement global CPU slicing and improve IRQ binding for Ascend NPUs (vllm-project#6945) [Triton] Centralize Ascend extension op dispatch in triton_utils (vllm-project#6937) [csrc][bugfix] Add compile-time Ascend950/910_95 compatibility for custom ops between CANN8.5 and 9.0 (vllm-project#6936) [300I][Bugfix] fix unquant model weight nd2nz error (vllm-project#6851) [doc] fix supported_models (vllm-project#6930) [CI] nightly test timeout (vllm-project#6912) [CI] Upgrade CANN to 8.5.1 (vllm-project#6897) [Model]Add Qwen3-Omni quantization Ascend NPU adaptation and optimization (vllm-project#6828) [P/D][v0.16.0]Adapt to RecomputeScheduler in vLLM 0.16.0 (vllm-project#6898) ...
### What this PR does / why we need it? The nightly test is currently failing due to a [timeout](https://github.com/vllm-project/vllm-ascend/actions/runs/22547280169/job/65326335134). As noted in vllm-project#6778, this issue can be resolved by applying this fix. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? run nightly test. Co-authored-by: guozr <guozr1997@hotmail.com>
4 participants
What this PR does / why we need it?
The nightly test is currently failing due to a timeout.
As noted in #6778, this issue can be resolved by applying this fix.
Does this PR introduce any user-facing change?
no
How was this patch tested?
run nightly test.