Skip to content

[CI]fix nightly multi node test error for wait for pod ready #6675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangxiyuan merged 1 commit into from
Feb 11, 2026
Merged

[CI]fix nightly multi node test error for wait for pod ready #6675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/e2e/nightly/multi_node/scripts/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ export LD_LIBRARY_PATH=/usr/local/lib:$LD_LIBRARY_PATH
# cann and atb environment setup
source /usr/local/Ascend/ascend-toolkit/set_env.sh
source /usr/local/Ascend/cann-8.5.0/share/info/ascendnpu-ir/bin/set_env.sh

set +eu
source /usr/local/Ascend/nnal/atb/set_env.sh
set -eu
Comment on lines +18 to +20
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While disabling strict mode with set +eu prevents the script from exiting due to issues within set_env.sh, it also suppresses errors if the source command itself fails (e.g., if the file doesn't exist). This could lead to the script continuing with an incomplete environment, causing non-obvious failures later.

To make this more robust, I suggest checking for the existence of the file before attempting to source it. This ensures that the script fails fast if the environment script is missing.

Suggested change
set +eu
source /usr/local/Ascend/nnal/atb/set_env.sh
set -eu
if [ -f "/usr/local/Ascend/nnal/atb/set_env.sh" ]; then
set +eu
source /usr/local/Ascend/nnal/atb/set_env.sh
set -eu
else
echo "ERROR: /usr/local/Ascend/nnal/atb/set_env.sh not found!" >&2
exit 1
fi


# Home path for aisbench
export BENCHMARK_HOME=${WORKSPACE}/vllm-ascend/benchmark

Expand Down
Loading