[CI]fix nightly multi node test error for wait for pod ready#6675
[CI]fix nightly multi node test error for wait for pod ready#6675wangxiyuan merged 1 commit intovllm-project:mainfrom
Conversation
Summary of ChangesHello @MrZ20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical CI failure in nightly multi-node tests by modifying a shell script. The change prevents the test script from prematurely exiting during environment setup, which was causing tests to hang at the 'wait for pod ready' stage. This ensures the stability and reliability of the multi-node test suite. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request addresses a hang in the nightly multi-node tests by temporarily disabling strict shell mode (set -eu) when sourcing a vendor environment script. The change is correct and effectively resolves the issue. I have provided one suggestion to improve the robustness of the script by ensuring it fails explicitly if the environment file is missing.
Additionally, as per the repository's style guide, I've suggested an improved pull request title and a more detailed summary below.
Suggested PR Title:
[CI][BugFix] Fix nightly multi-node test hangSuggested PR Summary:
### What this PR does / why we need it?
This PR fixes an issue where the nightly multi-node test hangs. The hang is caused by the `run.sh` script exiting prematurely when sourcing `/usr/local/Ascend/nnal/atb/set_env.sh`. This environment script is not compatible with the strict shell mode (`set -eu`) enabled at the beginning of `run.sh`.
The fix involves temporarily disabling strict mode (`set +eu`) before sourcing the problematic script and re-enabling it immediately after. This allows the setup to complete without errors, preventing the test from hanging.
### Does this PR introduce _any_ user-facing change?
No. This is a CI fix and does not affect end-users.
### How was this patch tested?
The fix is validated by observing that the nightly multi-node test pipeline now completes successfully without hanging.| set +eu | ||
| source /usr/local/Ascend/nnal/atb/set_env.sh | ||
| set -eu |
There was a problem hiding this comment.
While disabling strict mode with set +eu prevents the script from exiting due to issues within set_env.sh, it also suppresses errors if the source command itself fails (e.g., if the file doesn't exist). This could lead to the script continuing with an incomplete environment, causing non-obvious failures later.
To make this more robust, I suggest checking for the existence of the file before attempting to source it. This ensures that the script fails fast if the environment script is missing.
| set +eu | |
| source /usr/local/Ascend/nnal/atb/set_env.sh | |
| set -eu | |
| if [ -f "/usr/local/Ascend/nnal/atb/set_env.sh" ]; then | |
| set +eu | |
| source /usr/local/Ascend/nnal/atb/set_env.sh | |
| set -eu | |
| else | |
| echo "ERROR: /usr/local/Ascend/nnal/atb/set_env.sh not found!" >&2 | |
| exit 1 | |
| fi |
…oject#6675) ### What this PR does / why we need it? Fixes the issue where nightly multi-node tests hang during the "wait for pod ready" stage due to strict shell mode. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@1339784 Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: mikequan0425 <mikequan0425@foxmail.com>
…to qwen3next_rebase * 'main' of https://github.com/vllm-project/vllm-ascend: [Docs] Fix GLM-5 deploy command (vllm-project#6711) [npugraph_ex]enable npugraph_ex by default (vllm-project#6664) [doc]add GLM5.md (vllm-project#6709) [Model] GLM5 adaptation (vllm-project#6642) [Bugfix] Update target probs to target logits in rejection sample (vllm-project#6685) [Main][Ops] Make triton rope support index_selecting from cos_sin_cache (vllm-project#5450) [CI]fix nightly multi node test error for wait for pod ready (vllm-project#6675) [main to main] upgrade main 0210 (vllm-project#6673) [main][Quant] Remove unused rotation functions and parameters from W4A4 LAOS quantization (vllm-project#6648) [Test][BugFix] Fix torch.rand usage in triton penalty test (vllm-project#6680) Add Worker Interface:check_health (vllm-project#6681)
…oject#6675) ### What this PR does / why we need it? Fixes the issue where nightly multi-node tests hang during the "wait for pod ready" stage due to strict shell mode. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@1339784 Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: momochenchuw <chenchuw@huawei.com>
…oject#6675) ### What this PR does / why we need it? Fixes the issue where nightly multi-node tests hang during the "wait for pod ready" stage due to strict shell mode. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@1339784 Signed-off-by: MrZ20 <2609716663@qq.com>
…oject#6675) ### What this PR does / why we need it? Fixes the issue where nightly multi-node tests hang during the "wait for pod ready" stage due to strict shell mode. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@1339784 Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
…oject#6675) ### What this PR does / why we need it? Fixes the issue where nightly multi-node tests hang during the "wait for pod ready" stage due to strict shell mode. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@1339784 Signed-off-by: MrZ20 <2609716663@qq.com>
…oject#6675) ### What this PR does / why we need it? Fixes the issue where nightly multi-node tests hang during the "wait for pod ready" stage due to strict shell mode. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@1339784 Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
…oject#6675) ### What this PR does / why we need it? Fixes the issue where nightly multi-node tests hang during the "wait for pod ready" stage due to strict shell mode. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@1339784 Signed-off-by: MrZ20 <2609716663@qq.com>
…oject#6675) ### What this PR does / why we need it? Fixes the issue where nightly multi-node tests hang during the "wait for pod ready" stage due to strict shell mode. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@1339784 Signed-off-by: MrZ20 <2609716663@qq.com>
What this PR does / why we need it?
Fixes the issue where nightly multi-node tests hang during the "wait for pod ready" stage due to strict shell mode.
issue: https://github.com/vllm-project/vllm-ascend/actions/runs/21874130621/job/63137883914
bug:

Does this PR introduce any user-facing change?
How was this patch tested?