[refactor]Optimized the kvcache usage of Deepseek v3.2#6610
[refactor]Optimized the kvcache usage of Deepseek v3.2#6610wangxiyuan merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Wang Kunpeng <1289706727@qq.com>
Summary of ChangesHello @kunpengW-code, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the KV cache allocation and management for Deepseek v3.2 models, specifically targeting sparse attention mechanisms. The changes aim to optimize memory usage and improve compatibility by introducing a more dynamic and configuration-driven approach to determine KV cache tensor splitting and shaping, moving away from static or less precise calculations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request refactors the KV cache handling for Deepseek v3.2 models using sparse attention. The changes replace a hardcoded implementation based on FullAttentionSpec with a more robust and configurable approach using MLAAttentionSpec. This results in more accurate KV cache allocation and optimized memory usage. The changes look good and improve code clarity and maintainability.
As per the repository's style guide, I've provided suggestions for the pull request title and summary below.
Suggested PR Title:
[worker][refactor] Optimize kvcache usage for Deepseek v3.2Suggested PR Summary:
### What this PR does / why we need it?
This pull request refactors the KV cache allocation for Deepseek v3.2 models that use sparse attention. It replaces the use of `FullAttentionSpec` with `MLAAttentionSpec` and introduces a more principled way of calculating KV cache tensor split factors based on model configuration.
This change removes hardcoded values and correctly sizes the cache tensors, leading to optimized memory usage and improved code maintainability.
### Does this PR introduce _any_ user-facing change?
No, this is an internal optimization and does not introduce any user-facing changes.
### How was this patch tested?
CI tests should be sufficient to validate this internal refactoring.| self.model_config.hf_text_config.kv_lora_rank, | ||
| self.model_config.hf_text_config.qk_rope_head_dim, | ||
| self.model_config.hf_text_config.index_head_dim, | ||
| ] |
There was a problem hiding this comment.
it's better to return a tuple instead of a list.
…to qwen3next_rebase * 'main' of https://github.com/vllm-project/vllm-ascend: [Feat] 310p support MoE W8A8 quantizaition (vllm-project#6641) [TEST]add a qwen3-30b acc case with mooncake mempool (vllm-project#6244) [MOE Refactor] Remove QuantType in prepare_finalize.py (vllm-project#6534) [EPLB] Avoiding eplb's dependency on a specified model (vllm-project#6528) [Doc][Misc] Restructure tutorial documentation (vllm-project#6501) implement batch invariant with ascendc (vllm-project#6590) [Refact]Refact MLA/SFA weight prefetch to consist with moe weight prefetch (vllm-project#6629) [Misc] upgrade to vllm main (vllm-project#6646) [main][Docs] Fix spelling errors across documentation (vllm-project#6649) [bugfix]Fix no attribute 'data' when MLAPO is enable (vllm-project#6601) [DOC]Add Memcache Usage Guide (vllm-project#6476) [main][bugfix] Fix spec acceptance rate problem in vllm_0.15.0 (vllm-project#6606) [Test][LoRA] Add e2e test for base model inference (vllm-project#6624) [refactor]Optimized the kvcache usage of Deepseek v3.2 (vllm-project#6610) [Feat](sfa,dcp) support dcp for sfa (vllm-project#6563) [BugFix] Add support for rotary_dim parameter when using partial rope in rotary_embedding (vllm-project#6581) [fix bug] fix tensor mismatch bug in sigmoid operate test case (vllm-project#6619) [Kernel]: Optimize DispatchFFNCombine performance (vllm-project#6468) [MISC] Clean up useless env USE_OPTIMIZED_MODEL (vllm-project#6618)
…6610) ### What this PR does / why we need it? For deepseek v3.2, DSA use FullAttentionSpec, allocate 2 * mla page size bytes, and we use half of that for k cache in DSA However, the actual proportion of k cache is not high, which results in a large amount of kvcache being wasted. The proportion of discarded kvcache is (576-128)/(576 x 2) = 0.388. Run the same script to start DeepSeek V3.2 on a single A3 server. The following shows the comparison of kvcache usage: Before refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 15,872 tokens ``` After refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 25,984 tokens ``` This pull request refactors the KV cache allocation for Deepseek v3.2 models that use sparse attention. It replaces the use of `FullAttentionSpec` with `MLAAttentionSpec` and introduces a more principled way of calculating KV cache tensor split factors based on model configuration. This change removes hardcoded values and correctly sizes the cache tensors, leading to optimized memory usage and improved code maintainability. ### Does this PR introduce _any_ user-facing change? No, this is an internal optimization and does not introduce any user-facing changes. ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@d7e17aa --------- Signed-off-by: Wang Kunpeng <1289706727@qq.com> Signed-off-by: momochenchuw <chenchuw@huawei.com>
…6610) ### What this PR does / why we need it? For deepseek v3.2, DSA use FullAttentionSpec, allocate 2 * mla page size bytes, and we use half of that for k cache in DSA However, the actual proportion of k cache is not high, which results in a large amount of kvcache being wasted. The proportion of discarded kvcache is (576-128)/(576 x 2) = 0.388. Run the same script to start DeepSeek V3.2 on a single A3 server. The following shows the comparison of kvcache usage: Before refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 15,872 tokens ``` After refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 25,984 tokens ``` This pull request refactors the KV cache allocation for Deepseek v3.2 models that use sparse attention. It replaces the use of `FullAttentionSpec` with `MLAAttentionSpec` and introduces a more principled way of calculating KV cache tensor split factors based on model configuration. This change removes hardcoded values and correctly sizes the cache tensors, leading to optimized memory usage and improved code maintainability. ### Does this PR introduce _any_ user-facing change? No, this is an internal optimization and does not introduce any user-facing changes. ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@d7e17aa --------- Signed-off-by: Wang Kunpeng <1289706727@qq.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
…6610) ### What this PR does / why we need it? For deepseek v3.2, DSA use FullAttentionSpec, allocate 2 * mla page size bytes, and we use half of that for k cache in DSA However, the actual proportion of k cache is not high, which results in a large amount of kvcache being wasted. The proportion of discarded kvcache is (576-128)/(576 x 2) = 0.388. Run the same script to start DeepSeek V3.2 on a single A3 server. The following shows the comparison of kvcache usage: Before refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 15,872 tokens ``` After refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 25,984 tokens ``` This pull request refactors the KV cache allocation for Deepseek v3.2 models that use sparse attention. It replaces the use of `FullAttentionSpec` with `MLAAttentionSpec` and introduces a more principled way of calculating KV cache tensor split factors based on model configuration. This change removes hardcoded values and correctly sizes the cache tensors, leading to optimized memory usage and improved code maintainability. ### Does this PR introduce _any_ user-facing change? No, this is an internal optimization and does not introduce any user-facing changes. ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@d7e17aa --------- Signed-off-by: Wang Kunpeng <1289706727@qq.com>
…6610) ### What this PR does / why we need it? For deepseek v3.2, DSA use FullAttentionSpec, allocate 2 * mla page size bytes, and we use half of that for k cache in DSA However, the actual proportion of k cache is not high, which results in a large amount of kvcache being wasted. The proportion of discarded kvcache is (576-128)/(576 x 2) = 0.388. Run the same script to start DeepSeek V3.2 on a single A3 server. The following shows the comparison of kvcache usage: Before refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 15,872 tokens ``` After refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 25,984 tokens ``` This pull request refactors the KV cache allocation for Deepseek v3.2 models that use sparse attention. It replaces the use of `FullAttentionSpec` with `MLAAttentionSpec` and introduces a more principled way of calculating KV cache tensor split factors based on model configuration. This change removes hardcoded values and correctly sizes the cache tensors, leading to optimized memory usage and improved code maintainability. ### Does this PR introduce _any_ user-facing change? No, this is an internal optimization and does not introduce any user-facing changes. ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@d7e17aa --------- Signed-off-by: Wang Kunpeng <1289706727@qq.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
…6610) ### What this PR does / why we need it? For deepseek v3.2, DSA use FullAttentionSpec, allocate 2 * mla page size bytes, and we use half of that for k cache in DSA However, the actual proportion of k cache is not high, which results in a large amount of kvcache being wasted. The proportion of discarded kvcache is (576-128)/(576 x 2) = 0.388. Run the same script to start DeepSeek V3.2 on a single A3 server. The following shows the comparison of kvcache usage: Before refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 15,872 tokens ``` After refactoring ``` [kv_cache_utils.py:1307] GPU KV cache size: 25,984 tokens ``` This pull request refactors the KV cache allocation for Deepseek v3.2 models that use sparse attention. It replaces the use of `FullAttentionSpec` with `MLAAttentionSpec` and introduces a more principled way of calculating KV cache tensor split factors based on model configuration. This change removes hardcoded values and correctly sizes the cache tensors, leading to optimized memory usage and improved code maintainability. ### Does this PR introduce _any_ user-facing change? No, this is an internal optimization and does not introduce any user-facing changes. ### How was this patch tested? - vLLM version: v0.15.0 - vLLM main: vllm-project/vllm@d7e17aa --------- Signed-off-by: Wang Kunpeng <1289706727@qq.com>
What this PR does / why we need it?
For deepseek v3.2, DSA use FullAttentionSpec, allocate 2 * mla page size bytes, and we use half of that for k cache in DSA
However, the actual proportion of k cache is not high, which results in a large amount of kvcache being wasted. The proportion of discarded kvcache is (576-128)/(576 x 2) = 0.388.
Run the same script to start DeepSeek V3.2 on a single A3 server. The following shows the comparison of kvcache usage:
Before refactoring
After refactoring
This pull request refactors the KV cache allocation for Deepseek v3.2 models that use sparse attention. It replaces the use of
FullAttentionSpecwithMLAAttentionSpecand introduces a more principled way of calculating KV cache tensor split factors based on model configuration.This change removes hardcoded values and correctly sizes the cache tensors, leading to optimized memory usage and improved code maintainability.
Does this PR introduce any user-facing change?
No, this is an internal optimization and does not introduce any user-facing changes.
How was this patch tested?