[CI]Update triton ascend version in 3.2.0#6067
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request updates the triton-ascend version across several files. My main feedback is to avoid hardcoding the version string in multiple places to improve maintainability. I've suggested using a variable in the shell script and Sphinx substitutions in the documentation files to centralize the version string. This will make future updates simpler and less error-prone.
|
|
||
| ```bash | ||
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==3.2.0.dev20260105 | ||
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==3.2.0.dev2026012011 |
There was a problem hiding this comment.
To avoid hardcoding the version and improve maintainability, please use a Sphinx substitution here. This makes it consistent with other version variables like |vllm_ascend_version| and centralizes the configuration. You would need to define a new substitution, for example triton_ascend_version, in your Sphinx conf.py file.
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==3.2.0.dev2026012011 | |
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==|triton_ascend_version| |
|
|
||
| ```bash | ||
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==3.2.0.dev20260105 | ||
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==3.2.0.dev2026012011 |
There was a problem hiding this comment.
To avoid hardcoding the version and improve maintainability, please use a Sphinx substitution here. This makes it consistent with other version variables like |vllm_ascend_version| and centralizes the configuration. You would need to define a new substitution, for example triton_ascend_version, in your Sphinx conf.py file.
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==3.2.0.dev2026012011 | |
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==|triton_ascend_version| |
| export PATH=/usr/local/Ascend/tools/bishengir/bin:$PATH | ||
| which bishengir-compile | ||
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==3.2.0.dev20260105 | ||
| python3 -m pip install -i https://test.pypi.org/simple/ triton-ascend==3.2.0.dev2026012011 |
There was a problem hiding this comment.
The triton-ascend version is hardcoded here. This version string is also present in docs/source/tutorials/DeepSeek-V3.2.md and docs/source/tutorials/Qwen3-Next.md. To improve maintainability and avoid having to update it in multiple places, consider defining a variable for the version at the top of the script (e.g., TRITON_ASCEND_VERSION="3.2.0.dev2026012011") and using it here like triton-ascend==${TRITON_ASCEND_VERSION}.
4e9a47c to
e87709b
Compare
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
e87709b to
6d00bff
Compare
### What this PR does / why we need it? update triton ascend version in 3.2.0 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@d682094 Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com> Signed-off-by: huangning1995 <huangning12@huawei.com>
This reverts commit 6d4abad.
…to FIA_rebase * 'main' of https://github.com/vllm-project/vllm-ascend: [CI] Upgrade CANN to 8.5.0 (vllm-project#6070) Default enable MLAPO (vllm-project#5952) [Doc] Supplement PD separation parameters of DeepSeek V3.1 (vllm-project#6053) [Ascend] perf: optimize rope embedding with triton kernel for huge performance gain (vllm-project#5918) [Ops] update causal_conv1d_update (vllm-project#5984) [CI]Update triton ascend version in 3.2.0 (vllm-project#6067) [bugfix] fix the complex and potentially problematic generate_kv_idx. (vllm-project#5957)
### What this PR does / why we need it? update triton ascend version in 3.2.0 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@d682094 Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
### What this PR does / why we need it? update triton ascend version in 3.2.0 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@d682094 Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
### What this PR does / why we need it? update triton ascend version in 3.2.0 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@d682094 Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
### What this PR does / why we need it? update triton ascend version in 3.2.0 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@d682094 Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
### What this PR does / why we need it? update triton ascend version in 3.2.0 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@d682094 Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
### What this PR does / why we need it? update triton ascend version in 3.2.0 - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@d682094 Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
What this PR does / why we need it?
update triton ascend version in 3.2.0
Does this PR introduce any user-facing change?
How was this patch tested?